Community
Participate
Working Groups
Created attachment 265479 [details] image: Keys page, we could As a plugin developer, I will need to know the id of commands available in my Eclipse IDE and displayed in the Keys preference page. Not having the command ids, can make the code hard to maintain; i.e. Bug 507660. To fix this simply, without affecting the UI, we could modify the Keys preference page, and let the "Export CSV.." adds also the command ids to the exported list. A better solution would be displaying the command ids in the Keys page, but this might be controversial, as it would make more complex the Keys preference page.
(In reply to Patrik Suzzi from comment #0) > A better solution would be displaying the command ids in the Keys page, but > this might be controversial, as it would make more complex the Keys > preference page. I agree with the sentiment that showing IDs (even in a tooltip) just adds stuff to the UI which the average user won't need or understand. I can imagine, however, showing the contributing plugin (rather than the commandId) in a tooltip; it's (human-readable) name might be something end-users may understand and occasionally even find useful to disambiguate between commands with the same (human-readable) name.
See org.eclipse.ui.internal.keys.NewKeysPreferencePage org.eclipse.ui.internal.keys.model.KeyController#exportCSV
New Gerrit change created: https://git.eclipse.org/r/101374
The proposal and the patch are interesting and having commandId in CSV is indeed helpful. Just to make sure, at the moment, a user can export this file, but cannot import it? If so then I think the proposed change is good to get in 4.8.M3. If there is any supported workflow that allows importing this file, we need to make sure that this change still allows 1. importing new file (with commandId) to an older supported version 2. importing old file (wihtout commandId) to newer version still works
The export file is intended just for information purpose. There is no way to import it.
(In reply to Karsten Thoms from comment #5) > The export file is intended just for information purpose. There is no way to > import it. That's good news for us as it makes this patch safe for a future merge, although it sounds like a missing feature ;)
Gerrit change https://git.eclipse.org/r/101374 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=5af0d8f847a455312103fbca4700e1a0e11b1365
Thanks for the patch! Can you please add a note to the new and noteworthy about it?
Which document has to be edited?
(In reply to Karsten Thoms from comment #9) > Which document has to be edited? http://git.eclipse.org/c/gerrit/www.eclipse.org/eclipse/news.git/tree/4.8/M3/index.html Gerrit is enabled for the news.git repo.
New Gerrit change created: https://git.eclipse.org/r/105813
Gerrit change https://git.eclipse.org/r/105813 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=8f74c544030f0e70f2c6e0614206fb74c7c48bdc
Thanks a lot Joachim and Karsten!
