Bug 507411 - [Preferences] support for "dirtiness" on preference pages
Summary: [Preferences] support for "dirtiness" on preference pages
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo
Depends on:
Blocks: 497428
  Show dependency tree
 
Reported: 2016-11-11 11:29 EST by Mickael Istria CLA
Modified: 2017-11-03 11:59 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2016-11-11 11:29:37 EST 
For a given preference page, it's not visible if something was modified and required to be applied/saved to be taken into account. The "Apply" buttons only obeys to page validity state, not to page "dirtiness".
A user clicking Cancel on a wizard cannot be informed of whether some of their change require to be applied first.
Comment 1 Patrik Suzzi CLA 2016-11-12 11:34:51 EST 
IIUC, we should enable the Apply button only if the inputs are changed. Correct?

Could you please make an example we can use as a test case?

Thanks!
Comment 2 Mickael Istria CLA 2016-11-20 09:21:59 EST 
(In reply to Patrik Suzzi from comment #1)
> IIUC, we should enable the Apply button only if the inputs are changed.
> Correct?

The issue is much deeper: on a given preference page, there is no generic way to know whether the input changed and whether to change state of apply button. Each page is expected to do it individually, but it's actually often just kept enabled.