Bug 507090 - Icons for run as/debug as context menu
Summary: Icons for run as/debug as context menu
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.6   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.8 M5   Edit
Assignee: Patrik Suzzi CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted, usability
Depends on:
Blocks:
 
Reported: 2016-11-05 03:33 EDT by Mickael Istria CLA
Modified: 2018-01-24 04:27 EST (History)
4 users (show)

See Also:

Attachments
new look for the context menu (84.17 KB, image/png)
2017-12-11 19:15 EST, Patrik Suzzi CLA 		no flags Details
Another possible improvement is to add the icons to the top menu. (105.37 KB, image/png)
2017-12-12 04:07 EST, Patrik Suzzi CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2016-11-05 03:33:12 EDT 
The Run As and Debug As in context menu should use the icons from toolbar in order to provide faster detection and to highlight strong relationship between the menu and the toolbar entries.
Comment 1 Mickael Istria CLA 2016-11-05 03:35:47 EDT 
Tagging it as "hackathon-friendly"
Comment 2 Patrik Suzzi CLA 2017-12-11 19:15:49 EST 
Created attachment 271857 [details]
new look for the context menu

Please, see the new look of the context menu in the attached image.
Comment 3 Eclipse Genie CLA 2017-12-11 19:19:09 EST 
New Gerrit change created: https://git.eclipse.org/r/113193
Comment 4 Mickael Istria CLA 2017-12-12 03:13:28 EST 
Looks quite good to me.
I've put a target to M5. @Sarika: any objection to move forward quickly with this one?
Comment 5 Patrik Suzzi CLA 2017-12-12 04:07:09 EST 
Created attachment 271862 [details]
Another possible improvement is to add the icons to the top menu.

Please, let me know if you think we should add icons also to the top menu.
Comment 6 Mickael Istria CLA 2017-12-12 04:11:21 EST 
(In reply to Patrik Suzzi from comment #5)
> Please, let me know if you think we should add icons also to the top menu.

That would make sense as well to do it in the same commit.
Comment 7 Patrik Suzzi CLA 2017-12-12 05:52:47 EST 
Done.
Comment 8 Sarika Sinha CLA 2017-12-12 06:15:57 EST 
I am fine with it.
Comment 9 Mickael Istria CLA 2017-12-12 06:17:44 EST 
Merged then. Thanks Patrik!
Comment 11 Sarika Sinha CLA 2017-12-13 00:26:34 EST 
It will be good to add N&N for this as it's an visual enhancement.
Comment 12 Sarika Sinha CLA 2018-01-22 03:04:13 EST 
We don't have a N&N entry yet.

Verified using

Eclipse SDK

Version: Photon (4.8)
Build id: I20180121-2000
Comment 13 Sarika Sinha CLA 2018-01-24 04:05:45 EST 
Today is the last day to add N&N, please add it ASAP.
Comment 14 Mickael Istria CLA 2018-01-24 04:12:09 EST 
Do we really need a N&N entry for adding icons? It doesn't add a new workflow or API for adopters to understand. Users will just notice it (or not) and will keep doing business as usual without nothing new or different.
Comment 15 Sarika Sinha CLA 2018-01-24 04:27:12 EST 
(In reply to Mickael Istria from comment #14)
> Do we really need a N&N entry for adding icons? It doesn't add a new
> workflow or API for adopters to understand. Users will just notice it (or
> not) and will keep doing business as usual without nothing new or different.

Ok, we can skip it but I guess we will have to check if any screenshot was used for F1 documentation, if yes it needs to be updated.