Community
Participate
Working Groups
The content-type preference page shows (locked) suffix after locked content-type/file associations. It should rather use the nice lock icon that's available for progress reporting,
Could you please provide a reference or image to the lock icon that's available for progress reporting?
(In reply to Patrik Suzzi from comment #1) > Could you please provide a reference or image to the lock icon that's > available for progress reporting? https://github.com/eclipse/eclipse.platform.ui/blob/master/bundles/org.eclipse.e4.ui.progress/icons/full/progress/lockedstate.png
@Tony: some time ago, I was wondering whether the Eclipse Platform could host a silhouette icon. This "lock" would actually be the opposite use-case of the silhouette one: user defined and modifiable content would be using the silhouette icon, whereas system non modifiable would use the "lock" icon. So it would be interesting if those icons were using similar "style". WDYT?
New Gerrit change created: https://git.eclipse.org/r/85813
I've added the lock icon to the beginning of the cell item and removed the "(locked)" tags as well. It is currently grabbing the image directly from the Progress Manager image key, so it is best to discuss where we can copy over this icon or if this is adequate.
@Ian: I've got an alternative idea: what about using Unicode character for lock
(In reply to Mickael Istria from comment #6) > @Ian: I've got an alternative idea: what about using Unicode character for > lock Unless I did something wrong, it seems like bugzilla doesn't support Unicode...
(In reply to Mickael Istria from comment #7) > (In reply to Mickael Istria from comment #6) > > @Ian: I've got an alternative idea: what about using Unicode character for > > lock > > Unless I did something wrong, it seems like bugzilla doesn't support > Unicode... Hmm, apparently bugzilla states that its supported: https://www.bugzilla.org/features/#unicode how are you testing it to see if it supports it?
(In reply to Ian Pun from comment #8) > > Unless I did something wrong, it seems like bugzilla doesn't support > > Unicode... > > Hmm, apparently bugzilla states that its supported: > https://www.bugzilla.org/features/#unicode > how are you testing it to see if it supports it? See https://bugs.eclipse.org/bugs/show_bug.cgi?id=508300
(In reply to Mickael Istria from comment #9) > (In reply to Ian Pun from comment #8) > > > Unless I did something wrong, it seems like bugzilla doesn't support > > > Unicode... > > > > Hmm, apparently bugzilla states that its supported: > > https://www.bugzilla.org/features/#unicode > > how are you testing it to see if it supports it? > > See https://bugs.eclipse.org/bugs/show_bug.cgi?id=508300 I think (at least for now) we should stick to the lock image instead of moving to the Emoji, just so that it matches with the rest of the UI, unless we make a serious effort to move to emojis for a large portion of the platform. what do you think?
(In reply to Ian Pun from comment #10) > I think (at least for now) we should stick to the lock image instead of > moving to the Emoji, just so that it matches with the rest of the UI, unless > we make a serious effort to move to emojis for a large portion of the > platform. > > what do you think? Yeah, I think it makes sense, especially for this case when an icon already exists. The value of emojis is higher for icons that don't exist in the Eclipse world.
@Ian: could you please update the documentation about content-type preference page to mention this icon rather than the "(locked)" text?
On the same topic, it would be nice to place a silhouette for user-defined association.
Gerrit change https://git.eclipse.org/r/85813 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0571647ff2484d48d1b20f441bbf3bddbd068b7d
Patch has been merged into master. Closing.
