Bug 506000 - Smart import should not offer a special option whether to run in background
Summary: Smart import should not offer a special option whether to run in background
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 4.8 M6   Edit
Assignee: Jonas Hungershausen CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2016-10-14 11:15 EDT by Dani Megert CLA
Modified: 2018-02-27 15:04 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2016-10-14 11:15:49 EDT
Smart import should not offer special option whether to run in background.

We already have a global preference for that.
Comment 1 Lars Vogel CLA 2016-10-14 11:56:06 EDT
+1 for this but I think Mickael had concerns that the import in background might be confusing for the user.
Comment 2 Mickael Istria CLA 2016-10-14 12:06:28 EDT
(In reply to Lars Vogel out-of-office until 21.10.2016 from comment #1)
> +1 for this but I think Mickael had concerns that the import in background
> might be confusing for the user.

Actually, I have concerns about several operations in the background that can be confusing for users. Basically, for any operation that needs to be completed before user can continue their workflow (import in one instance of those), I believe it's better to present progress to user rather than presenting some incomplete or unusable state.
That said, I'm also for consistency, so +1 on using the global property to decide whether to show report or not. If this is an issue in term of usability, that will be an interesting example to consider when deciding to change the global preference value.
Comment 3 Dani Megert CLA 2016-10-14 12:23:00 EDT
Before we changed the default, the user got the progress dialog with an option to run everything in the background. Obviously, the other way is harder to achieve.
Comment 4 Dani Megert CLA 2016-10-28 09:08:02 EDT
(In reply to Mickael Istria from comment #2)
> (In reply to Lars Vogel out-of-office until 21.10.2016 from comment #1)
> > +1 for this but I think Mickael had concerns that the import in background
> > might be confusing for the user.
> 
> Actually, I have concerns about several operations in the background that
> can be confusing for users. Basically, for any operation that needs to be
> completed before user can continue their workflow (import in one instance of
> those), I believe it's better to present progress to user rather than
> presenting some incomplete or unusable state.

Well, for those cases, the option to run in the background should not be there at all.
Comment 5 Lars Vogel CLA 2017-06-30 11:55:22 EDT
(In reply to Dani Megert from comment #0)
> Smart import should not offer special option whether to run in background.
> 
> We already have a global preference for that.

+1

I discussed the current behavior with several of my customers and either:

1.) They don't care (no opinion)
2.) Find the current blocking import wizard annoying

I suggest we remove this extra option and use the global preference.
Comment 6 Lars Vogel CLA 2018-02-20 15:55:33 EST
Jonas, this is a bit more challenging, as promised. Can you have a look?

To trigger the dialog, use for example the Git repository view -> Import projects. On the page after pressing finish you see a "Run in background" flag which should get removed and the global constant from Window -> Preference -> Always run in background should be used.
Comment 7 Eclipse Genie CLA 2018-02-22 07:18:59 EST
New Gerrit change created: https://git.eclipse.org/r/117938
Comment 8 Lars Vogel CLA 2018-02-22 11:13:06 EST
Just to document this:

We have the "Always run in Background" option. Offering another "Always run in Background" option specialize for a dialog is very confusing for the end users who expects that all dialogs honor the "Always run in Background".

This bug does not change the logic of the dialog, projects are either imported in the foreground or background, depending on the user choice. It just removes the UX inconsistency.
Comment 9 Dani Megert CLA 2018-02-27 10:57:41 EST
NOTE: OTHER import wizards do not allow to run in the background (even if the preference says so) for arguments brought up here. It can be very confusing for users to see partially imported state/projects.
Comment 10 Lars Vogel CLA 2018-02-27 15:04:44 EST
Thanks, Jonas.