Bug 505842 - [generic editor] Test failures in official build in HoverTest
Summary: [generic editor] Test failures in official build in HoverTest
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.7 RC1   Edit
Assignee: Mickael Istria CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2016-10-13 03:45 EDT by Dani Megert CLA
Modified: 2018-08-23 12:57 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2016-10-13 03:45:00 EDT
N20161012-2000

http://download.eclipse.org/eclipse/downloads/drops4/N20161012-2000/testresults/html/org.eclipse.ui.genericeditor.tests_ep47N-
unit-mac64_macosx.cocoa.x86_64_8.0.html
Comment 1 Eclipse Genie CLA 2016-10-13 04:55:20 EDT
New Gerrit change created: https://git.eclipse.org/r/83089
Comment 2 Mickael Istria CLA 2016-10-13 04:56:47 EDT
I easily reproduced them with PDE tests, although they pass with Tycho.
Comment 4 Mickael Istria CLA 2016-10-13 05:23:15 EDT
Last patch works with PDE and Tycho.
Comment 6 Mickael Istria CLA 2016-11-08 10:51:57 EST
This test failure only happened once, in a build showing other unusual test failures. I'm tempted to close the issue as WORKSFORME and to blame (without any other proof) a bad environment mood for this specific set of failures.
@Dani: is this acceptable?
Comment 7 Dani Megert CLA 2016-11-08 10:59:28 EST
(In reply to Mickael Istria from comment #6)
> This test failure only happened once, in a build showing other unusual test
> failures. I'm tempted to close the issue as WORKSFORME and to blame (without
> any other proof) a bad environment mood for this specific set of failures.
> @Dani: is this acceptable?

Sure. We can reopen if it happens again.
Comment 9 Dani Megert CLA 2017-05-10 06:01:42 EDT
Those failures cause noise. Please either fix or disable them for M7.
Comment 10 Mickael Istria CLA 2017-05-10 06:11:39 EDT
I'd really like to fix them once and for all, but I admit I didn't find a good way to do it, as it involves waiting for popups to show up.
@Alex: would you please give me a hand with this one? It involves generating SWT events and waiting properly for a shell to be shown. I hope you can figure out how to make it more "stable" or think about a better way to achieve this.
Comment 11 Dani Megert CLA 2017-05-12 10:26:09 EDT
(In reply to Mickael Istria from comment #10)
> I'd really like to fix them once and for all

That's nice, but disable them for RC1 if you can't fix them.
Comment 12 Eclipse Genie CLA 2017-05-15 04:53:42 EDT
New Gerrit change created: https://git.eclipse.org/r/97056
Comment 14 Mickael Istria CLA 2017-05-15 06:57:17 EDT
(In reply to Eclipse Genie from comment #13)
> Gerrit change https://git.eclipse.org/r/97056 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/
> ?id=36f184f16f456d9e67029e34ca68c98c9689d46f

This patch should help. Let's leave the issue open for now and see if this has improved things in next builds.
I believe I found a way to avoid some sporadic issue with completion; and for the hoverTest, I simply skip it on Windows as I don't have a clue about why it's failing there.
Comment 15 Mickael Istria CLA 2017-05-16 01:26:55 EDT
Tests on Windows seem OK, but another test seems unstable.
Comment 16 Eclipse Genie CLA 2017-05-16 03:46:29 EDT
New Gerrit change created: https://git.eclipse.org/r/97179
Comment 18 Mickael Istria CLA 2017-05-17 02:33:57 EDT
Last test suite (with the patches merged) didn't show any error regarding Generic Editor tests.
Comment 19 Eclipse Genie CLA 2018-08-22 14:59:56 EDT
New Gerrit change created: https://git.eclipse.org/r/127877
Comment 20 Dani Megert CLA 2018-08-23 12:57:05 EDT
(In reply to Eclipse Genie from comment #19)
> New Gerrit change created: https://git.eclipse.org/r/127877

What is this doing here? This bug is closed and VERIFIED since 2017.