Bug 504082 - Remove CycleBaseHandler superclass, used in Ctrl(+Shift)+F6/F7/F8
Summary: Remove CycleBaseHandler superclass, used in Ctrl(+Shift)+F6/F7/F8
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.13 M1   Edit
Assignee: Rolf Theunissen CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 504088 504089 504090 504091
Blocks:
  Show dependency tree
 
Reported: 2016-10-05 10:13 EDT by Patrik Suzzi CLA
Modified: 2019-06-23 14:34 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrik Suzzi CLA 2016-10-05 10:13:17 EDT 
FilteredTableBaseHandler, the superclass for Ctrl+E handler, can easily replace CycleBaseHandler, the superclass for the following handlers:

- CycleViewHandler, to select a view with Ctrl(+Shift)+F6 
- CycleEditorHandler, to select an editor with Ctrl(+Shift)+F7 
- CyclePerspectiveHandler, to select a perspective with Ctrl(+Shift)+F8 
- CyclePageHandler, to select a page in the current editor with Alt(+Shift)+F7 

Reasons for replacing: 
- We'll have one single superclass for Ctrl+E and all the other Commands listed above.
- FilteredTableBaseHandler is based on CycleBaseHandler, and the risks of swapping are minor(swap already tested during  fix)
- FilteredTableHandler improves CycleBaseHandler, i.e. looks better in Dark Theme.
- In future, we could easily improve the above commands, by showing a filtered list instead of a list, just by changing a boolean flag.

This is the umbrella bug, I'll add one bug per each Handler listed above

See also:
Bug 368977 and change https://git.eclipse.org/r/#/c/82333/
Comment 1 Patrik Suzzi CLA 2016-10-15 07:57:59 EDT 
After the blocking tasks are completed, we should remove the CycleBaseHandler class, that won't be referenced anymore.
Comment 2 Lars Vogel CLA 2016-10-31 12:13:06 EDT 
Mass move to M4.
Comment 3 Dani Megert CLA 2018-05-24 12:54:37 EDT 
Removing target milestone for all bugs that are not major or above.
Comment 4 Dani Megert CLA 2018-05-25 04:06:24 EDT 
> Removing target milestone for all bugs that are not major or above.

Of course I meant "major or below".

Sorry for the noise!
Comment 5 Eclipse Genie CLA 2019-06-20 16:08:59 EDT 
New Gerrit change created: https://git.eclipse.org/r/144575