Bug 50356 - [Viewers] API Request involving StructuredViewer#handleOpen()
Summary: [Viewers] API Request involving StructuredViewer#handleOpen()
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M7   Edit
Assignee: Michael Valenta CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2004-01-21 16:04 EST by Michael Valenta CLA
Modified: 2004-02-20 21:03 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Valenta CLA 2004-01-21 16:04:38 EST 
The StructuredViewer#handleOpen() is speced to be internal use only in the 
Javadoc (i.e it states that subclass should not invoke the method). However, 
this method is used by both Compare and Team to provide a context menu action 
to populate the text area of a compare input. I would like to correct this 
situation. This would involve either changing the spec on the method or 
duplicating the code of handleOpen in those places that require it (i.e. use 
fireOpen directly). The former is the easiest for us but the later is not a 
lot of work either. I wanted to run it by UI for an opinion before proceeding.
Comment 1 Nick Edgar CLA 2004-01-22 10:39:19 EST 
If the intent is for you to fire an open event in response to a context menu 
action, it would be better for you to call fireOpen(OpenEvent) yourself (i.e. 
duplicate the code).  The intent of this method is to be the -handler- for the 
open event from the OpenStrategy.
Comment 2 Michael Valenta CLA 2004-01-22 14:05:03 EST 
OK, I'll update our code and then pass the bug report on to Compare.
Comment 3 Nick Edgar CLA 2004-01-22 19:07:53 EST 
ok, thanks
Comment 4 Michael Valenta CLA 2004-01-23 08:33:58 EST 
Reopening to modify Team and Compare
Comment 5 Jean-Michel Lemieux CLA 2004-02-20 21:03:54 EST 
fireOpen is called in our tree viewers.