Bug 5031 - API - Review comments related to resource change notifications
Summary: API - Review comments related to resource change notifications
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 2.0   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Jeff McAffer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-16 16:41 EDT by Rodrigo Peretti CLA
Modified: 2001-11-08 09:49 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rodrigo Peretti CLA 2001-10-16 16:41:33 EDT
Build 204

In many APIs we have the following line of code:

 * <li> Resource changes are disallowed during resource change event 
notification.</li>

It comes from before we "relaxed" this statement. Now we can change resources 
during specific lifecycle notifications. It should be changed to something 
like (depending on the operation context):

 * <li> Resource changes are disallowed during some resource change event 
notifications.</li>

or, to be more specific:

 * <li> Resource changes are disallowed during resource POST_CHANGE event 
notification.</li>

 * <li> Resource changes are disallowed during resource PRE_CLOSE event 
notification.</li>

 * <li> Resource changes are disallowed during resource PRE_DELETE event 
notification.</li>
Comment 1 John Arthorne CLA 2001-11-05 13:43:36 EST
Fixed.  New comment says,

 * <li> Resource changes are disallowed during certain types of resource change 
 *       event notification. See IResourceChangeEvent for more details.</li>


Also added this comment in a couple of places where it was missing (several 
IMarker methods and IFolder#delete).
Comment 2 Rodrigo Peretti CLA 2001-11-08 09:49:11 EST
Fixed in v209