Community
Participate
Working Groups
Created attachment 264371 [details] window title screenshot on KDE Follow up on Bug 502025 comment 4. Currently Eclipse add following elements to the window title: 1) Short workspace name (content is user customizable, can be empty) 2) Perspective name (indirectly customizable by perspective name) 3) File path of the active editor 4) Application name (fixed, like "Eclipse IDE") 5) Full workspace path (can be switched on/off) So today it looks like: egit_workspace - Java - org.eclipse.jgit/build.properties - Eclipse SDK - /data/egit_workspace The proposal is: 1) Remove perspective part completely 2) Move the editor part to the first place 3) Show either short or long workspace name, but never both at same time 4) Application name should always be the last part of the title The result would look like: org.eclipse.jgit/build.properties - /data/egit_workspace - Eclipse SDK org.eclipse.jgit/build.properties - egit_workspace - Eclipse SDK The goal is to reduce noise in the title and move the most important parts first (because most window manager / task bars show only few first characters of the title if they have not enough space).
+1 less is more
Some people prefer having different workspaces open at the same time. To avoid confusion they rename perspectives. Having perspective name instead of filename in the title bar is very user-friendly and allows you to quickly find desired workspace and perspective. This is probably not the most correct/fluent workflow.
(In reply to Rustam Ershtukaev from comment #2) > Some people prefer having different workspaces open at the same time. To > avoid confusion they rename perspectives. Having perspective name instead of > filename in the title bar is very user-friendly and allows you to quickly > find desired workspace and perspective. Right, this is a valid use case, and actually with 4.6 those people don't need to rename perspectives at all anymore, because the short workspace name (configurable) is shown in the first place. Given that, I would like to update the proposal: The proposal is: 1) Remove perspective part completely 2) Show either short or long workspace name, but never both at same time 3) Application name should always be the last part of the title The result will be in default state: egit_workspace - org.eclipse.jgit/build.properties - Eclipse SDK after enabling "show wokspace path in window title" option: /data/egit_workspace - org.eclipse.jgit/build.properties - Eclipse SDK
(In reply to Rustam Ershtukaev from comment #2) > Some people prefer having different workspaces open at the same time. To > avoid confusion they rename perspectives. That is why we added the workspace to the title in Neon.
(In reply to Andrey Loskutov from comment #3) > The proposal is: > 2) Show either short or long workspace name, but never both at same time +1 for showing only the short by default, -1 for never. If user wants to enable both, we should not prevent that. IIRC we have already existing config for both options.
(In reply to Lars Vogel from comment #5) > (In reply to Andrey Loskutov from comment #3) > > The proposal is: > > > 2) Show either short or long workspace name, but never both at same time > > +1 for showing only the short by default, -1 for never. If user wants to > enable both For what reason? This is how it looks like today: egit_workspace - Java - org.eclipse.jgit/build.properties - Eclipse SDK - /data/egit_workspace What is the reason to see "egit_workspace" twice?
(In reply to Andrey Loskutov from comment #6) > What is the reason to see "egit_workspace" twice? OK, I'm convinced. Lets go for never.
+1, for the proposal from comment #3, as less distraction is better! Perhaps we could add an option to let the user choose to see edited file: full-path vs filename-only
Created attachment 264428 [details] Proposed location for the preference Shall we add the preference under Window > Preferences > General > Appearance ?
(In reply to Patrik Suzzi from comment #9) > Shall we add the preference under Window > Preferences > General > > Appearance ? Andrey, can you answer that? I have no preference for the new preference. ;-)
(In reply to Lars Vogel from comment #10) > (In reply to Patrik Suzzi from comment #9) > > Shall we add the preference under Window > Preferences > General > > > Appearance ? > > Andrey, can you answer that? I have no preference for the new preference. ;-) We have the preference already at General-Workspace. Just adding something like "show full path" (or other way around) next to it would be sufficient. I have no ide right now but I hope it is clear what I mean.
New Gerrit change created: https://git.eclipse.org/r/85354
Created attachment 265465 [details] Anim gif showing the discussed behavior Please, see the attached anim gif displaying the discussed behavior. Note: in the changeset 1 [#1], you can see tracing to compare this new implementation with the previous one. [#1] https://git.eclipse.org/r/#/c/85354/1
Created attachment 265471 [details] anim gif: new UI, as discussed in comments The new ui has radio buttons to switch between full path and workspace name only.
Gerrit change https://git.eclipse.org/r/85354 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=9660175ce66aa3e4e72f44b20a1688033f50be2a
In master now.
New Gerrit change created: https://git.eclipse.org/r/85995
Added N&N explaining the change with simple words.
Gerrit change https://git.eclipse.org/r/85995 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=b91e8044e42e5542df9e72f80f0f643913807d17
(In reply to Patrik Suzzi from comment #16) > In master now. Thanks Patrik!
I'm sorry, but that change is a no go. People who use multiple Eclipse windows are now doomed because all have the exact same title. I can no longer directly switch to the window which e.g. has the Debug perspective. I have to manually bring the windows to front to see what's in there. Another no go is that I can no longer show both, the title and the location. The -showlocation command line argument not only locks the location in the title, but also disallows to show the workspace name (only). To give you an idea: before this change my workspace title looked like this: Workspace Name - Perspective - Product - Location now it is Location - Product Two essential information pieces are gone! This either needs to be improved for M4 or reverted and moved to M5.
Created attachment 265744 [details] Picture showing information loss
(In reply to Dani Megert from comment #22) > Created attachment 265744 [details] > Picture showing information loss The main idea behind this bug was simplifying the title removing redundant items. In comment#1 you can see the discussed requirements. Two of them are responsible for the changes you don't like: 1. Remove the perspective name completely. Motivation: the user can check visually the selected perspective in the perspective switcher, and perspective name in the title bar is redundant. 2. Show either the workspace name or the location. Motivation: the workspace name is already visible as the last segment of the location path. According to your comments, we should: - add again the perspective name, I suppose before the product name - show again the workspace name, I suppose as the first element. Plus, there are additional changes I should perform: - use checkboxes instead of radio buttons for workspace path and name - add checkboxes to let the user customise and choose whether to show or not the perspective name. Does this sounds ok?
(In reply to Patrik Suzzi from comment #23) > (In reply to Dani Megert from comment #22) > > Created attachment 265744 [details] > > Picture showing information loss > > The main idea behind this bug was simplifying the title removing redundant > items. > In comment#1 you can see the discussed requirements. Two of them are > responsible for the changes you don't like: > 1. Remove the perspective name completely. Motivation: the user can check > visually the selected perspective in the perspective switcher, and > perspective name in the title bar is redundant. This is only true if you work with one window only. My work model is to have several full screen windows, each with a single perspective. With the perspective name removed one can no longer directly switch to a specific window. > 2. Show either the workspace name or the location. Motivation: the workspace > name is already visible as the last segment of the location path. Not true. The workspace might be labelled Oxygen while being located at fooBar. > According to your comments, we should: > - add again the perspective name, I suppose before the product name > - show again the workspace name, I suppose as the first element. Yes. > Plus, there are additional changes I should perform: > - use checkboxes instead of radio buttons for workspace path and name > - add checkboxes to let the user customise and choose whether to show or not > the perspective name. > > Does this sounds ok? Yes. Maybe even better (not for M4), we could think about giving full control to the user. Currently, he cannot choose the order and he cannot choose to get rid of the product name.
For me the workspace location is the least important information - definitely less important than the active file name.
(In reply to Dani Megert from comment #21) > I'm sorry, but that change is a no go. People who use multiple Eclipse > windows are now doomed because all have the exact same title. This will still be true if those people use exact same perspective in all windows. You misused perspectives to identify different windows. Probably you just want to have a per-window name. > I can no > longer directly switch to the window which e.g. has the Debug perspective. I > have to manually bring the windows to front to see what's in there. That would be also solved by providing a window related part of the name. > Another no go is that I can no longer show both, the title and the location. Which both by default contains information derived from location, but agree that this is not possible anymore. > The -showlocation command line argument not only locks the location in the > title, but also disallows to show the workspace name (only). OK to only toggle full path on/off. > To give you an idea: before this change my workspace title looked like this: > Workspace Name - Perspective - Product - Location > now it is > Location - Product > Two essential information pieces are gone! *By default* workspace part was same as last location segment, so for "default" users they only miss now perspective name, which was misused by advanced users as as window identifier and just eat space for the rest :-). > This either needs to be improved for M4 or reverted and moved to M5. I would not revert, but gradually improve. (In reply to Dani Megert from comment #25) > For me the workspace location is the least important information - > definitely less important than the active file name. For me the opposite is true, but this is just a sign that we should improve the proposal. The updated proposal is: 1) Allow user to select which parts (see below) should be shown 2) Application name should always be the last part of the title (I think everyone agrees on that). 3) Offer to select following parts to be shown (via checkboxes), in the order they are specified here: [x] Show workspace name (on by default) Workspace name: <text: last location segment> [x] Show unique window id (on by default) [x] Only for multiple windows (on by default) Window id: <text: perspective name> [x] Show current editor title (on by default) [x] Product name (on by default) [ ] Full workspace path (off by default) If all checkboxes above would be disabled by user, "Product name" should be enabled and shown. The result will be in default state with ONE window: egit_workspace - org.eclipse.jgit/build.properties - Eclipse SDK with TWO windows and same perspective: egit_workspace - Java - org.eclipse.jgit/build.properties - Eclipse SDK egit_workspace - Java - org.eclipse.jgit/build.properties - Eclipse SDK with TWO windows and different perspectives: egit_workspace - Java - org.eclipse.jgit/build.properties - Eclipse SDK egit_workspace - Debug - org.eclipse.jgit/build.properties - Eclipse SDK with THREE windows, same perspective and custom window names: egit_workspace - Whatever#1 - org.eclipse.jgit/build.properties - Eclipse SDK egit_workspace - Whatever#2 - org.eclipse.jgit/build.properties - Eclipse SDK egit_workspace - Whatever#3 - org.eclipse.jgit/build.properties - Eclipse SDK After enabling all checkboxes except "Only for multiple windows": egit_workspace - Java - org.eclipse.jgit/build.properties - /data/egit_workspace - Eclipse SDK
Created attachment 265747 [details] updated proposal
(In reply to Andrey Loskutov from comment #26) > (In reply to Dani Megert from comment #21) > > I'm sorry, but that change is a no go. People who use multiple Eclipse > > windows are now doomed because all have the exact same title. > > This will still be true if those people use exact same perspective in all > windows. You misused perspectives to identify different windows. The perspective name was there - I did not misuse it, but just used the information that was there. And it was put there on purpose. > Probably you just want to have a per-window name. No, I don't want to be forced to set a name per window. The perspective name perfectly works for me. > > I can no > > longer directly switch to the window which e.g. has the Debug perspective. I > > have to manually bring the windows to front to see what's in there. > > That would be also solved by providing a window related part of the name. See my previous comment. > > Another no go is that I can no longer show both, the title and the location. > > Which both by default contains information derived from location, but agree > that this is not possible anymore. People who use the option to explicitly set a workspace name are doomed because they can't see both. From comment 24: " The workspace might be labelled Oxygen while being located at fooBar " so, both pieces of the information differ and can be relevant. > > To give you an idea: before this change my workspace title looked like this: > > Workspace Name - Perspective - Product - Location > > now it is > > Location - Product > > Two essential information pieces are gone! > > *By default* workspace part was same as last location segment, so for > "default" users they only miss now perspective name, which was misused by > advanced users as as window identifier and just eat space for the rest :-). Again, no misuse and nothing advanced. The beginner could use that information to distinguish windows. Showing information in the title that allows to distinguish the windows is the whole point. That's why e.g. Firefox shows the active page as first element. That's also the reason why we've put the product name and the path at the end - it's the least important piece of information. > > This either needs to be improved for M4 or reverted and moved to M5. > > I would not revert, but gradually improve. Fine with me, as long as the perspective name is there in M4 (or the option to put it back). > The updated proposal is: > 1) Allow user to select which parts (see below) should be shown +1 > 2) Application name should always be the last part of the title (I think > everyone agrees on that). +1 > 3) Offer to select following parts to be shown (via checkboxes), in the > order they are specified here: > > [x] Show workspace name (on by default) > Workspace name: <text: last location segment> > [x] Show unique window id (on by default) > [x] Only for multiple windows (on by default) > Window id: <text: perspective name> Don't introduce a new term "id" here, just use "perspective name" > [x] Show current editor title (on by default) Should be "active editor path" > [x] Product name (on by default) > [ ] Full workspace path (off by default) +1. Using -showlocation must show the path and lock the option (checked). And only that option. > If all checkboxes above would be disabled by user, "Product name" should be > enabled and shown. We don't need that restriction. Give the full power to the user and reduce code complexity.
Created attachment 265749 [details] image: a simplified preference page (In reply to Andrey Loskutov from comment #27) > Created attachment 265747 [details] > updated proposal I think the UI is too complex, so the users can not understand immediately the preferences. I suggest simplifying the preference page as you can see in this new attachment. So doing we'll have an IDE more immediate and easy to use.
(In reply to Patrik Suzzi from comment #29) > Created attachment 265749 [details] > image: a simplified preference page > > (In reply to Andrey Loskutov from comment #27) > > Created attachment 265747 [details] > > updated proposal > > I think the UI is too complex, so the users can not understand immediately > the preferences. I suggest simplifying the preference page as you can see in > this new attachment. So doing we'll have an IDE more immediate and easy to > use. +1, but workspace path needs to go to the end (in the preferences).
Created attachment 265753 [details] Anim gif: new UI and behavior Please, provide feedback based on the behavior yuo can see in the attached animated gif. The UI is like you can see below, where 'd' means true by default. [ ] Show perspective name [d] Show workspace name Workspace name [_____________________] [ ] Show full workspace path Workspace path [---------------------]
(In reply to Patrik Suzzi from comment #31) > Created attachment 265753 [details] > Anim gif: new UI and behavior > > Please, provide feedback based on the behavior yuo can see in the attached > animated gif. > > The UI is like you can see below, where 'd' means true by default. > > [ ] Show perspective name > [d] Show workspace name > Workspace name [_____________________] > [ ] Show full workspace path > Workspace path [---------------------] You changed the order again. It must be Workspace name Perspective name Full path [Product name] In the preferences and also in the window title.
The option to remove the "Eclipse SDK" entry from the title would also be nice. At least for me this info has absolutely no value.
(In reply to Lars Vogel from comment #33) > The option to remove the "Eclipse SDK" entry from the title would also be > nice. At least for me this info has absolutely no value. It's common to have the app name at the end, but I'm fine having an option to remove it.
(In reply to Dani Megert from comment #34) > (In reply to Lars Vogel from comment #33) > > The option to remove the "Eclipse SDK" entry from the title would also be > > nice. At least for me this info has absolutely no value. > > It's common to have the app name at the end, but I'm fine having an option > to remove it. App name allows tests or window managers "detect" applications automagically. This is the reason I proposed to make an extra option to show/hide it.
(In reply to Andrey Loskutov from comment #35) > (In reply to Dani Megert from comment #34) > > (In reply to Lars Vogel from comment #33) > > > The option to remove the "Eclipse SDK" entry from the title would also be > > > nice. At least for me this info has absolutely no value. > > > > It's common to have the app name at the end, but I'm fine having an option > > to remove it. > > App name allows tests or window managers "detect" applications > automagically. This is the reason I proposed to make an extra option to > show/hide it. I'll fix this shortly as suggested by Dani in #c32, and adding one checkbox to show/hide the product [d] Show workspace name Workspace name [_____________________] [ ] Show perspective name [ ] Show full workspace path Workspace path [---------------------] [ ] Show full workspace path Note: [d] means checked by defaule
(In reply to Patrik Suzzi from comment #36) I correct myself: [d] Show workspace name Workspace name [_____________________] [ ] Show perspective name [ ] Show full workspace path Workspace path [---------------------] [ ] Show product name [d] == means checked by default
Created attachment 265755 [details] Image: see the proposed UI, plus note disabled fields on force location In the attached image you can see the UI proposed, and incorporating the latest ideas. Below, you can see the final version of UI and defaults, that I'm going to submit shortly: [d] Show workspace name Workspace name [_____________________] [ ] Show perspective name [ ] Show full workspace path Workspace path [---------------------] [d] Show product name Where, [d] == means checked by default
New Gerrit change created: https://git.eclipse.org/r/86658
The provided change fixes the behaviour as discussed. Tonight I'll update the N&N accordingly. Please, let me know if you're ok with this change. @Andrey, @Lars: hope you don't mind if I added you for review. It would be great having your opinion
(In reply to Patrik Suzzi from comment #40) > The provided change fixes the behaviour as discussed. > Tonight I'll update the N&N accordingly. > > Please, let me know if you're ok with this change. > > @Andrey, @Lars: hope you don't mind if I added you for review. It would be > great having your opinion I've just pushed updated change set, where I fixed order of the parts placed in the title, and also removed already used mnemonics - we get out of free letters on the page! The last one is an indication that we should provide a dedicated "Window title" page under General -> Appearance -> Window Title. @Dani: I would propose we move the "title" preferences to the new page in M5 and for M4 just merge the last patch, are you OK with that?
(In reply to Andrey Loskutov from comment #41) > (In reply to Patrik Suzzi from comment #40) > > The provided change fixes the behaviour as discussed. > > Tonight I'll update the N&N accordingly. > > > > Please, let me know if you're ok with this change. > > > > @Andrey, @Lars: hope you don't mind if I added you for review. It would be > > great having your opinion > I've just pushed updated change set, where I fixed order of the parts placed > in the title, and also removed already used mnemonics - we get out of free > letters on the page! > > The last one is an indication that we should provide a dedicated "Window > title" page under General -> Appearance -> Window Title. > > @Dani: I would propose we move the "title" preferences to the new page in M5 > and for M4 just merge the last patch, are you OK with that? I'll look at it this morning.
(In reply to Andrey Loskutov from comment #41) > I've just pushed updated change set, where I fixed order of the parts placed > in the title, and also removed already used mnemonics - we get out of free > letters on the page! Thanks guys! I verified that it works as expected. Please submit the change. > The last one is an indication that we should provide a dedicated "Window > title" page under General -> Appearance -> Window Title. That's overkill for just the window title. We can give more control to the user if we replace the current check boxes with a simpler UI similar to the one on the CVS > Label Decorations | Text Decorations page. With that, the user cannot only choose what to show, but also in which order, and he can even choose the separators. Plus, it will only take one line/field on the preference page.
(In reply to Dani Megert from comment #43) > (In reply to Andrey Loskutov from comment #41) > > I've just pushed updated change set, where I fixed order of the parts placed > > in the title, and also removed already used mnemonics - we get out of free > > letters on the page! > > Thanks guys! I verified that it works as expected. Please submit the change. I've submitted the change, but either due our bugzilla issues or due Gerrit issues there was no update on the ticket. > > The last one is an indication that we should provide a dedicated "Window > > title" page under General -> Appearance -> Window Title. > > That's overkill for just the window title. We can give more control to the > user if we replace the current check boxes with a simpler UI similar to the > one on the CVS > Label Decorations | Text Decorations page. With that, the > user cannot only choose what to show, but also in which order, and he can > even choose the separators. Plus, it will only take one line/field on the > preference page. Should we create a new enhancement request for this? This will not fit into M4 anymore. If yes, we can close this as fixed.
(In reply to Andrey Loskutov from comment #44) > > We can give more control to the > > user if we replace the current check boxes with a simpler UI similar to the > > one on the CVS > Label Decorations | Text Decorations page. With that, the > > user cannot only choose what to show, but also in which order, and he can > > even choose the separators. Plus, it will only take one line/field on the > > preference page. > > Should we create a new enhancement request for this? Yes, please cc me. > This will not fit into M4 anymore. Definitely agree on that :-)
Gerrit change https://git.eclipse.org/r/86658 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=cf13fc29144f6abeee62b0cde0b0d7fd823abe1a
I've filed bug 508912, so we can close this one now. @Patrik: can you please update N&N with the new screenshot?
Verified in eclipse-SDK-I20161208-0830-win32-x86_64. Looks good except for one minor detail: when using -showlocation, the preference is not checked. Filed bug to track that.
New Gerrit change created: https://git.eclipse.org/r/86756
(In reply to Andrey Loskutov from comment #47) > @Patrik: can you please update N&N with the new screenshot? Done with Gerrit change: https://git.eclipse.org/r/86756
Gerrit change https://git.eclipse.org/r/86756 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=b8a072a53f7b1879874363f16acca8c75cadda81
Thanks to you all. I think I could fix bug 508934 (-showlocation) in few hours. When is the deadline to submit for M4?
(In reply to Patrik Suzzi from comment #52) > When is the deadline to submit for M4? It was Wednesday except for fixes for major issues.
New Gerrit change created: https://git.eclipse.org/r/86848
With this fix I'm improving the quality of the images in N&N.
Gerrit change https://git.eclipse.org/r/86848 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=ca40fd80ec144f0abf3848a4ab4e18dc55944b5b
