Community
Participate
Working Groups
First of all: I know that there is some discussion underway how to do things actions like Rename "inline" (i.e., without opening a dialog). But maybe there's an easy fix in the meantime for the following very annoying behavior: When renaming a large number of files (e.g., adding a common prefix), you proceed as follows: - Select a file in the Package Explorer - Use the Rename keyboard shortcut - Perform the necessary change in the Rename Resource dialog - Hit enter - As this looses my previous selection in the Package Explorer, you have to use the *mouse* to select the next file. Would would be great if the selection were not lost. Then you could simply hit Arrow Down and proceed with renaming using the keyboard only. AFAICT, this is not possible at the moment.
Package Explorer is provided by JDT. If you see the same for Project Explorer, please open a new bug. +1 for this request, super annoying. Same happens if I do a Text search, it looses its selection.
I do not see this issue with 4.7 M2 build on Windows 7. After rename, you can use the arrow keys to move to the next/previous file in Package Explorer. If it reproducible on Mac then it could be an issue with SWT.
(In reply to Noopur Gupta from comment #2) > I do not see this issue with 4.7 M2 build on Windows 7. After rename, you > can use the arrow keys to move to the next/previous file in Package Explorer. > > If it reproducible on Mac then it could be an issue with SWT. On the Mac (4.7 M2): - Renaming .java in the package explorer works - Renaming non-java (.txt or.xml) in the package explorer loses focus, like described in comment#0
(In reply to Till Brychcy from comment #3) > On the Mac (4.7 M2): > - Renaming .java in the package explorer works > - Renaming non-java (.txt or.xml) in the package explorer loses focus, like > described in comment#0 Wow. That was quick. You are right. I just verified this myself with 4.7 M2 under OS X myself. The Rename Compilation Unit dialog (.java) keeps the selection, but the Rename Resource dialog (.txt) looses it. Did some further experiments: - Rename Compilation Unit: keeps selection - Rename Package: keeps selection - Rename Source Folder: keeps selection - Rename Java Project: keeps selection - Rename Resource: looses selection - Rename Folder: looses selection - Rename Project: looses selection Interestingly, all these dialogs are instances of org.eclipse.ltk.internal.ui.refactoring.RefactoringWizardDialog2.
Did you try using up/down arrow keys after rename? On Windows, the selection on Java elements is shown clearly but the selection on resources is shown with dotted lines. It could be that the selection is not clearly visible on Mac for resources.
(In reply to Noopur Gupta from comment #5) > Did you try using up/down arrow keys after rename? On Windows, the selection > on Java elements is shown clearly but the selection on resources is shown > with dotted lines. It could be that the selection is not clearly visible on > Mac for resources. When I hit the down arrow key after closing the Rename Resource dialog, a clearly visible selection shows up -- on the *first* element of the Package Explorer. (If I hit the up arrow key, it shows up on the *last* element.) Thus, it clearly forgot the previous selection, which was an element somewhere in the middle.
Created attachment 264332 [details] Screenshot (In reply to Andreas Sewe from comment #6) > (In reply to Noopur Gupta from comment #5) > > Did you try using up/down arrow keys after rename? On Windows, the selection > > on Java elements is shown clearly but the selection on resources is shown > > with dotted lines. It could be that the selection is not clearly visible on > > Mac for resources. > > When I hit the down arrow key after closing the Rename Resource dialog, a > clearly visible selection shows up -- on the *first* element of the Package > Explorer. (If I hit the up arrow key, it shows up on the *last* element.) > > Thus, it clearly forgot the previous selection, which was an element > somewhere in the middle. On Windows, this issue does not happen and the previous selection is remembered even for resources (shown with dotted lines - see screenshot). Looks like a Mac related issue. Moving to SWT.
For the case of renaming .java files it works because the renamed file is selected by the selectReveal-call in org.eclipse.jdt.internal.ui.refactoring.reorg.RenameSelectionState.restore(Object) To me it looks like on Windows, the renamed (non-java) file is not selected, but just focused after renaming.
