Community
Participate
Working Groups
When you open a bug in Mylyn, you can right click and copy details: - ID - URL - Summary and URL However, most of the time I want "ID + Summary" If anyone with mylyn knowledge has time, would you be able to add this context menu? Thank you for your time.
Summary and URL actually includes the ID, e.g. 501868: In "copy details" please add "ID and Summary" https://bugs.eclipse.org/bugs/show_bug.cgi?id=501868 So I guess what you're asking for is just the first line of that? I agree it would be useful. It should be straightforward to add this. The code is in org.eclipse.mylyn.internal.builds.ui.commands.CopyDetailsHandler if you want to contribute.
Yes, just the first line of code. Thanks for pointing to the location, I'll look into writing a patch.
New Gerrit change created: https://git.eclipse.org/r/81726
(In reply to Eclipse Genie from comment #3) > New Gerrit change created: https://git.eclipse.org/r/81726 Could someone review? Someone turned on save actions but didn't take the time to format all of the source code, which resulted in somewhat tedious editing. After this patch I'll submit another patch to do a bit of re-formatting and refactoring of a few variable names.
Save actions have always been on, but unfortunately the Eclipse formatter changed its behaviour over time so code that hasn't been touched in a while is no longer correctly formatted.
(In reply to comment #5) > Save actions have always been on, but unfortunately the Eclipse formatter > changed its behaviour over time so code that hasn't been touched in a while is > no longer correctly formatted. Oh, I see. That makes sense. Thanks for info.
In regards to this bug and related: Bug 296760 – prepend bug prefix to text that is generated by copy details https://bugs.eclipse.org/bugs/show_bug.cgi?id=296760 There seems to be confusion/ambiguity with the patch I've submitted: https://git.eclipse.org/r/#/c/81726/ Let's clarify to stay focused and productive :-). # 1) Refactoring There was a suggestion to rename SUMMARY_URL to ID_SUMMARY_URL. I had the same line of thought. I suggest I'll submit a second followup patch with bunch of refactored changes. This is to make it more clear as to what new features are introduced and what is only re factored. Also when I save some files, the formatter changes many lines. It would be easier for me to submit a separate re factoring patch for me. # 2) Divisor between ID and SUMMARY. By default, the standard divisor is ": ". So currently copy details for ID_SUMMARY, for bugzilla looks like: Bug 501868: In "copy details" please add "ID and Summary" There is no technical issue with ": ", but usually bugzilla's summary is separated by a ' - ', ex: Bug 501868 - In "copy details" please add "ID and Summary" The patch in 501868 doesn't break backwards compatibility by introducing support for overriding separator and makes the exported clipboard content look more similar to what it would look like if you'd manually copy the title. It's a relatively small change (+- 5 lines of code) and follows the convention used by "getTaskPrefix()" already present in the code. Is there a reason 'not' to include support for overriding separator ' - '? If not, can we go ahead and introduce it with the patch? # 3) Prefix before ID. The ID_SUMMARY requires a prefix so that it becomes linkable. ex this becomes linkable in bugzilla: Bug 123 <Summary> This does not: 123 <Summary> Since there is no URL as with SUMMARY_URL, there is no alternative link one can follow. I would suggest to keep the prefix in ID_SUMMARY for proper linking to work. Now with SUMMARY_URL, there is a link included, ex: 296760 - <SUMMARY> https://bugs.eclipse.org/bugs/show_bug.cgi?id=296760 So strictly speaking the prefix there is not needed. Further, if you copy something between different bugzilla instances (ex from Eclipse Bugzilla to Gnome bugzilla), having the prefix causes incorrect linking as the "Bug 123" links to the local bugzilla and the URL links to the foreign bugzilla. I would suggest that we have the prefix only in ID_SUMMARY and not in SUMMARY_URL. Further, there is a commented line of code in SUMMARY_URL //sb.append(TasksUiInternal.getTaskPrefix(task.getConnectorKind())) Jaxsun asked me to remove it. I would be happy to remove it, however I would suggest that I do so in a separate patch just to keep things tidy. So moving forward, if there are objections or concerns about the above, please let me/us know. If there are no objections/concerns, I suggest (one of you guys?) merges the patch: https://git.eclipse.org/r/#/c/81726/ (Btw, I updated typo so that ": " is used as default instead of " ") And I will subsequently submit a follow-up patch where I do some code refactoring.
I would prefer to keep connectors consistent and not support overriding the separator. I don't think it provides enough value to justify the inconsistency for people who use multiple connectors, or the extra API for connector developers to understand. I agree we should have a prefix for the ID and summary option. It's not worthing pushing a review just to remove one line of commented code. We like to do that kind of maintenance as part of our regular work instead of triggering a build and having people spend time approving the change.
(In reply to Sam Davis from comment #8) > I would prefer to keep connectors consistent and not support overriding the > separator. I don't think it provides enough value to justify the > inconsistency for people who use multiple connectors, or the extra API for > connector developers to understand. > > I agree we should have a prefix for the ID and summary option. > > It's not worthing pushing a review just to remove one line of commented > code. We like to do that kind of maintenance as part of our regular work > instead of triggering a build and having people spend time approving the > change. Thank you for your feedback, I'll adjust patch accordingly.
(In reply to Leo Ufimtsev from comment #9) > Thank you for your feedback, I'll adjust patch accordingly. I've updated the patch (patch set 3). To my knowledge, I implemented all the suggested changes. (removal of task-id-summary-separator, refactoring of enum/variables etc...). Please review. Let me know if I missed something or if there is further improvement to be made. Thank you for your time and feedback.
Gerrit change https://git.eclipse.org/r/81726 was merged to [master]. Commit: http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.tasks.git/commit/?id=2abd17c2ef00212b7ebd680d0c866ced9195d167
New Gerrit change created: https://git.eclipse.org/r/83729
Gerrit change https://git.eclipse.org/r/83729 was merged to [master]. Commit: http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.tasks.git/commit/?id=6f243ab3e3cb0b54df183e5c98452f8b552efcec
