Community
Participate
Working Groups
Created attachment 264107 [details] Screenshot I20160906-0800 Problems view configuration dialog has wrong background colors, see screenshot. The text field and tree background needs to be white when the controls are enabled. Seems to be another theming-induced bug. Does not happen when I switch to a classic theme.
Happens already in 4.7 M1, but does not happen in 4.6.
I checked in org.eclipse.ui.themes\css\e4_default_win7.css. removing the following lines, the discussed background displays correctly. /* We also have to force the background mode (the * Label/ToolBar in the heading should inherit it). */ swt-background-mode: 'force'; I didn't see any side effect in Label/ToolBars, under Window 10. Hence I'm going to provide three changes, for Win, Linux, and Mac, and ask for review.
New Gerrit change created: https://git.eclipse.org/r/81046
The change above is for windows. I verified the problem shows up also in Linux. see: http://imgur.com/CutX61y.png Soon I'll submit the change for Linux, and ask for review.
I was wrong, the problem did not show also in Linux. However, for consistency, we should commit the same changes, also in Linux. Adding Lars in c/c as he might provide directions.
I tested the change https://git.eclipse.org/r/#/c/81046/ in differnet OSs. The change consists of removing the line below: swt-background-mode: 'force'; Below you can see the results: Windows: without change: http://i.imgur.com/fqpTzEd.png with the change: http://imgur.com/E8IHbyI.png --> the change fixes the issue. Linux (GTK3) without change == with the change: http://i.imgur.com/CutX61y.png --> the change does nothing. Linux (GTK2) without change: http://i.imgur.com/jdgWmSa.png with the change: http://i.imgur.com/fsdtDOi.png --> the change has partial effect, if applied, it looks like Mac Design (see below). Mac without change == with the change: http://i.imgur.com/4DUwQeo.png --> the change does nothing.
Update: Please, disregard comments 5 and 6. After double checking the changes applied on all systems, I can tell the issue is fixed by the proposed change, consisting of removing the below line from CSS: swt-background-mode: 'force'; Please, look at the full visual comparison below, looking at BOTH the "Contains" Text AND the "Types" TreeView. COMPARISON: Windows: without change: http://i.imgur.com/fqpTzEd.png with the change: http://imgur.com/E8IHbyI.png --> fixes both Text and TreeView (un-greyed). Linux (GTK3) without change: http://i.imgur.com/CutX61y.png with the change: http://i.imgur.com/NJhDCBC.png --> fixes the "Contains" Text. Linux (GTK2) without change: http://i.imgur.com/jdgWmSa.png with the change: http://i.imgur.com/fsdtDOi.png --> Fixes the "Types" TreeView. Mac without change: http://i.imgur.com/4DUwQeo.png with the change: http://i.imgur.com/tkYzjQY.png --> Fixes the "Contains" Text. Hence, I'm going to submit and ask review for the three changes.
New Gerrit change created: https://git.eclipse.org/r/81065
New Gerrit change created: https://git.eclipse.org/r/81066
Gerrit change https://git.eclipse.org/r/81046 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=878ec30fd9a6a3a89b16c7121ca8900f6c360a89
The above change fixes the background colors in Windows
Gerrit change https://git.eclipse.org/r/81065 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=929247af7347a24b8f5fce25c57a25911f0b5e1a
The above applies to Linux GTK
Gerrit change https://git.eclipse.org/r/81066 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ddcff77089c66ef6d84115f8d988801861c29314
And the last, above, is for Mac Cocoa
