Bug 500818 - [Quick Access] Press F2 to focus for a Persistent Dialog
Summary: [Quick Access] Press F2 to focus for a Persistent Dialog
Status: CLOSED DUPLICATE of bug 500618
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.13   Edit
Assignee: Mickael Istria CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility, noteworthy, usability
Depends on: 500618
Blocks:
  Show dependency tree
 
Reported: 2016-09-04 06:22 EDT by Patrik Suzzi CLA
Modified: 2019-05-20 05:12 EDT (History)
3 users (show)

See Also:


Attachments
quick access: press F2 to make a persistent dialog (69.92 KB, image/png)
2016-09-04 06:22 EDT, Patrik Suzzi CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrik Suzzi CLA 2016-09-04 06:22:55 EDT
Created attachment 263951 [details]
quick access: press F2 to make a persistent dialog

If you open Quick Access, and switch the focus out, the Quick Access Dialog closes. 

I would like the option to press a key, e.g. F2, to make the QuickAccess dialog persistent, so I can switch focus to the IDE, and back to the Quick Access, while keeping the same list of results.

Please, see the attached image to get an idea.
http://imgur.com/n91XYZG.png
Comment 1 Mickael Istria CLA 2018-03-08 05:23:02 EST
This is actually a major accessibility bug. Indeed, screen readers will read the content of popup only if it has focus, so the fact that it can't have focus prevent people using a screen reader to take advantage of the Quick Access field and Ctrl+3 shortcut, that would be very profitable for them.
Comment 2 Patrik Suzzi CLA 2018-03-09 12:13:42 EST
I'm going to look into this.
Comment 3 Dani Megert CLA 2018-05-10 10:18:45 EDT
(In reply to Patrik Suzzi from comment #2)
> I'm going to look into this.

Moving to RC1. Please remove/change the target milestone if you can't do it for RC1.
Comment 4 Mickael Istria CLA 2018-11-19 16:22:31 EST
@Patrik: any news? Is it achievable for 4.10?
Comment 5 Dani Megert CLA 2018-12-04 11:36:55 EST
Moving target milestone to 4.11 for all bugs that are major or above.
Comment 6 Mickael Istria CLA 2018-12-04 14:22:38 EST
Resetting assignee as Patrik seems not really involved on this issue, so let's make clear anyone else would be welcome to help.
Comment 7 Mickael Istria CLA 2018-12-20 17:19:17 EST
So I'm trying using Eclipse IDE with the Screen Reader that's part of the default accessibility kit on Fedora 29.
I don't think the search dialog itself is to blame for the screen reader issue: If I start a runtime IDE from my workspace (with a basic application, no .product) the table of quick assist is properly read by the screen reader.
If I pick an IDE with the same versions of about everything, the table is not read. I can often hear the Screen Reader talking about being in an "Eclipse SDK Panel" (I'm using EPPs of Eclipse IDE) when it doesn't happen for the plain application. I'm wondering whether there isn't a subtility in product packaging or window lifecycle that makes that EPP package rename the "panel" and confuse screen readers, that do not properly realize the table is a widget of the current  window.
Comment 8 Eclipse Genie CLA 2018-12-21 04:28:46 EST
New Gerrit change created: https://git.eclipse.org/r/134374
Comment 9 Mickael Istria CLA 2018-12-21 04:31:22 EST
So actually, let's ignore the screenreader part as opening the quickfix dialog solves it.

(In reply to Eclipse Genie from comment #8)
> New Gerrit change created: https://git.eclipse.org/r/134374

This patch open the QuickAssistDialog instead of the floating table when one presses F2 from QuickAssist search field.
Some pitfalls:
* F2 is hardcoded. I guess we need a declared key binding for that, don't we?
* This new possibility doesn't show up in UI. It should show an extra message at the bottom of the table.
Comment 10 Dani Megert CLA 2018-12-21 04:39:25 EST
(In reply to Mickael Istria from comment #9)
> So actually, let's ignore the screenreader part as opening the quickfix
> dialog solves it.
Then the summary should be updated.

 
> (In reply to Eclipse Genie from comment #8)
> > New Gerrit change created: https://git.eclipse.org/r/134374
> 
> This patch open the QuickAssistDialog instead of the floating table when one
> presses F2 from QuickAssist search field.
> Some pitfalls:
> * F2 is hardcoded. I guess we need a declared key binding for that, don't we?
> * This new possibility doesn't show up in UI. It should show an extra
> message at the bottom of the table.
I presume you can assign the bug to yourself.
Comment 11 Mickael Istria CLA 2018-12-21 06:07:55 EST
New patch adds a label to inform user of the new features. Remaining issues:
* When an editor is open and active, it captures for F2 shortcut even is quickfix is enabled. I'm wondering whether the "Editing Text" shortcut context should also check that editor is not only active, but also has focus
* the F2 is still hardcoded.
Comment 12 Mickael Istria CLA 2019-01-02 05:19:19 EST
(In reply to Mickael Istria from comment #11)
> * When an editor is open and active, it captures for F2 shortcut even is
> quickfix is enabled. I'm wondering whether the "Editing Text" shortcut
> context should also check that editor is not only active, but also has focus

Dealing with key binding enablement here is hard. The scopes are not dynamic enough and bypassing the KeyBinding from the QuickAssist may lead to bad results (there are some operations that user may want to still be available, some other not, hard to sort out which ones remain enabled and which ones don't).
I suggest the shortcut to turn the shell into a dialog to be Alt+F2. Any objection?
Comment 13 Dani Megert CLA 2019-01-03 11:13:01 EST
(In reply to Eclipse Genie from comment #8)
> New Gerrit change created: https://git.eclipse.org/r/134374

This does not fix this bug on Windows.
Comment 14 Lars Vogel CLA 2019-02-19 03:32:13 EST
Mass change, please reset target if you still planning to fix this for 4.11.
Comment 15 Mickael Istria CLA 2019-05-14 06:07:44 EDT
As Quick-Access is now extensible, there is even more urge for improving its accessibility.
However, I don't think I'll be able to work on it for 4.12, so targeting for 4.13
Comment 16 Mickael Istria CLA 2019-05-20 05:12:48 EDT
I'm closing this one as bug 500618 is a more generic approach to better accessibility for Quick Access.

*** This bug has been marked as a duplicate of bug 500618 ***