500206 – Improve Gtk theme override mechanism

Bug 500206 - Improve Gtk theme override mechanism

Summary: Improve Gtk theme override mechanism

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	SWT (show other bugs)
Version:	4.6
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.7 M2
Assignee:	Alexander Kurtakov
QA Contact:

URL:
Whiteboard:
Keywords:	ui

Depends on:
Blocks:

Reported:	2016-08-24 09:44 EDT by Alexander Kurtakov
Modified:	2016-11-18 12:24 EST (History)
CC List:	3 users (show)

See Also:	Gerrit Change Git Commit 507604

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexander Kurtakov

2016-08-24 09:44:48 EDT

Load gtk version specific css from files to ease maintaining editing it as doing it in the java file as string was too error prone.
Also provide a mechanism for users to append their own css to allow people tweaking for best experience according to their own experience.

Comment 1 Eric Williams

2016-08-24 11:04:00 EDT

This should be pretty straightforward since the GTK3.20 CSS selectors are part of the GTK API now. There won't be as much (or any) changes as the 3.14 - 3.18 CSS selectors.

Comment 2 Eclipse Genie

2016-08-24 11:11:11 EDT

New Gerrit change created: https://git.eclipse.org/r/79638

Comment 3 Eclipse Genie

2016-08-26 03:20:17 EDT

Gerrit change https://git.eclipse.org/r/79638 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=cfc86c0a0761337df72c1e36b4b8184ab52cae23

Comment 4 Leo Ufimtsev

2016-08-26 10:54:49 EDT

Nice patch, this opens doors for Eclipse theaming.