Bug 500117 - Remove old import wizard "Existing Projects into Workspace" from import menu
Summary: Remove old import wizard "Existing Projects into Workspace" from import menu
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 506047
Blocks:
  Show dependency tree
 
Reported: 2016-08-23 07:18 EDT by Lars Vogel CLA
Modified: 2020-01-15 11:15 EST (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2016-08-23 07:18:47 EDT
We should remove the "Existing Projects into Workspace" wizard from the menu and focus our work on the new smart project import wizard. 

The only "feature" missing in this new import dialog is to copy the projects into the workspace which we consider anyway bad practice.
Comment 1 Lars Vogel CLA 2016-08-23 07:20:17 EDT
Reason for removal: the new import wizard configures also the projects. And for the user is bad to have several options to import existing projects.
Comment 2 Dani Megert CLA 2016-08-25 11:18:43 EDT
(In reply to Lars Vogel from comment #0)
> We should remove the "Existing Projects into Workspace" wizard from the menu
> and focus our work on the new smart project import wizard. 

There is no "work" pending for the "old" one, so, you can already focus your work now - go ahead! ;-)


> The only "feature" missing in this new import dialog is to copy the projects
> into the workspace which we consider anyway bad practice.

Are you sure?


The "old" one allows to import the project as-is, while the new one might either enhance, or destroy/modify that existing project.

If you can guarantee here for 100 % that an existing project will be imported as is, then I'm +1, otherwise -1.
Comment 3 Lars Vogel CLA 2016-09-12 14:51:34 EDT
(In reply to Dani Megert from comment #2)
> If you can guarantee here for 100 % that an existing project will be
> imported as is, then I'm +1, otherwise -1.

This dependents on the install project configurators.
Comment 4 Mickael Istria CLA 2016-09-13 02:24:19 EDT
I'm also reluctant to remove this specific wizard. As the smart importer is based on contributions (which quality we do not control), it's possible for an external plugin to break it.
For people who only import a directory with Eclipse projects, the specific wizard is IMO safer to use as it won't get "polluted" by some folders detected as projects although they have no .project.

There is also a difference between both wizards: at the moment, the smart import one doesn't allow to copy content into workspace (and current feedback is that people are happy with it as it, so it may not even be worth adding this feature).

However, the current name "Existing projects into workspace" is too generic and somehow conflicts with the smart import one, so I believe rather than removing it, we could consider renaming it to "Exising Eclipse projects".
Comment 5 Lars Vogel CLA 2016-09-13 02:43:11 EDT
(In reply to Mickael Istria from comment #4)

> However, the current name "Existing projects into workspace" is too generic
> and somehow conflicts with the smart import one, so I believe rather than
> removing it, we could consider renaming it to "Existing Eclipse projects".

I still find it confusing for the user to have two import wizards. And "Existing Eclipse projects" does not tell the user that no additional configuration will be done. IIRC we have a bug for making the additional configurators selectable for the user. If we fix that, I think the old wizard can be removed.
Comment 6 Dani Megert CLA 2017-04-14 10:40:13 EDT
(In reply to Mickael Istria from comment #4)
> I'm also reluctant to remove this specific wizard. As the smart importer is
> based on contributions (which quality we do not control), it's possible for
> an external plugin to break it.
> For people who only import a directory with Eclipse projects, the specific
> wizard is IMO safer to use as it won't get "polluted" by some folders
> detected as projects although they have no .project.
> 
> There is also a difference between both wizards: at the moment, the smart
> import one doesn't allow to copy content into workspace (and current
> feedback is that people are happy with it as it, so it may not even be worth
> adding this feature).
> 
> However, the current name "Existing projects into workspace" is too generic
> and somehow conflicts with the smart import one, so I believe rather than
> removing it, we could consider renaming it to "Exising Eclipse projects".

+1 to all of that.
Comment 7 Patrik Suzzi CLA 2017-04-14 11:39:27 EDT
To have only one import, we could rename use the smart import as default, and provide two checkbox options:

1. - [v] Use smart import to configure the project
2. - [ ] Copy Existing Eclipse Projects into workspace

Where 1. and 2. are mutually exclusive and the 1.tooltip says: "Smart import depends on contributions. Unckeck to import Eclipse projects without modifications"

So doing: 
- With the first checkbox checked by default, we'll use the smart import.
- When 1. is unchecked we'll use the old default import
- When 2. is selected, we perform the default import and copy projects into workspace
Comment 8 Mickael Istria CLA 2017-04-14 13:37:27 EDT
(In reply to Patrik Suzzi from comment #7)
> To have only one import

IMO, we don't need one import, having several remains simpler than introducing additional options to some existing wizards.
Comment 9 Dani Megert CLA 2017-04-18 10:22:11 EDT
(In reply to Mickael Istria from comment #8)
> (In reply to Patrik Suzzi from comment #7)
> > To have only one import
> 
> IMO, we don't need one import, having several remains simpler than
> introducing additional options to some existing wizards.

+1.
Comment 10 Nobody - feel free to take it CLA 2020-01-15 11:12:46 EST
It is unclear whether this issue was solved - the ticket's Status has both "RESOLVED" and "WONTFIX".
Comment 11 Mickael Istria CLA 2020-01-15 11:15:11 EST
So let's say CLOSED WONTFIX.