Bug 499232 - Project explorer - Show filters in drop-down.
Summary: Project explorer - Show filters in drop-down.
Status: REOPENED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2016-08-05 09:23 EDT by Ben Tatham CLA
Modified: 2017-05-24 11:01 EDT (History)
4 users (show)

See Also:


Attachments
image: project explorer vs package explorer (135.01 KB, image/png)
2016-08-10 10:16 EDT, Patrik Suzzi CLA
no flags Details
image: filters are already available in Project Explorer (193.81 KB, image/png)
2016-08-12 11:51 EDT, Patrik Suzzi CLA
no flags Details
Screenshot of Package Explorer view menu (6.46 KB, image/png)
2016-08-16 02:15 EDT, Michael Fröschen CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Tatham CLA 2016-08-05 09:23:48 EDT
The Package Explorer conveniently has a link to the Filters and shows recently/commonly used ones directly in the drop-down of the view.  Project Explorer should do the same.

For example, I find it very convenient to quickly show/hide Closed Projects.
Comment 1 Patrik Suzzi CLA 2016-08-10 10:16:37 EDT
Created attachment 263548 [details]
image: project explorer vs package explorer

I can reproduce the issue in Eclipse SDK 
Version: Oxygen (4.7)
Build id: I20160803-2000
OS: Windows 10, v.10.0, x86_64 / win32
Comment 2 Patrik Suzzi CLA 2016-08-12 11:51:43 EDT
Created attachment 263574 [details]
image: filters are already available in Project Explorer

Filters are already available in Project Explorer, under the Customize View menu item.
Comment 3 Patrik Suzzi CLA 2016-08-12 11:53:20 EDT
Closing as Worksforme.

Please, re-open if you want to suggest improvements to the visibility of Filters in Project Explorer.
Comment 4 Ben Tatham CLA 2016-08-12 11:53:32 EDT
Comment on attachment 263574 [details]
image: filters are already available in Project Explorer

Yes - the Filters are available, but this bug is about making them more easily accessible directly on the drop-down, as they are in the Package Explorer.
Comment 5 Ben Tatham CLA 2016-08-12 11:54:53 EDT
Further, Package Explorer shows a list of commonly used Filters directly in the drop-down which is also what this bug is requesting.
Comment 6 Patrik Suzzi CLA 2016-08-12 12:36:51 EDT
I'd like to help. Please be more specific with the requirements. 

(In reply to Ben Tatham from comment #4)
> Comment on attachment 263574 [details]
> image: filters are already available in Project Explorer
> 
> Yes - the Filters are available, but this bug is about making them more
> easily accessible directly on the drop-down, as they are in the Package
> Explorer.

- Do you want a different name for "Customize View..." or you want another menu Item? 
- If you want another menu item, describe what you expect to see in there. 

(In reply to Ben Tatham from comment #5)
> Further, Package Explorer shows a list of commonly used Filters directly in
> the drop-down which is also what this bug is requesting.

Please, specify the list of common filters. 
As we can not see those filters in attachment 263574 [details], I expect a dynamic list.
Can you provide a screenshot or a list of filter names with descriptions, and the condition when the filter should be active?

Thanks for helping in making Eclipse better.
Comment 7 Michael Fröschen CLA 2016-08-16 02:15:28 EDT
Created attachment 263605 [details]
Screenshot of Package Explorer view menu

It is not that hard to understand what is being requested here, since the requests are already as specific as it can be.
I will try to be even more specific by explicitly describing the workflows.

Workflow to set a filter in the Package Explorer:

1. Open View Menu
2. Click Filters Menu Item
3. Choose a filter
4. Hit OK

Thats 4 clicks to set a filter and no need to think since it is intuitive

Workflow to set a filter in the Project Explorer:

1. Open View Menu
2. Click "Customize View..." Menu Item
3. Choose a filter
4. Hit OK

Also 4 clicks, but not (!) intuitive. Never would i expect to find filters in a dialog opened by a menu item that is called "Customize View...".

So the first request is to find a proper name for that menu item or create a new menu item that is called filters and that opens the filter selection dialog.


I attached a Screenshot that displays the Package Explorer view menu.
In that screenshot a recently used Filter is displayed.
I am now able to click that filter which will activate it (it is then checked) and then i can click it again and thus deactivate it.
This is convenient and easy.
Comment 8 Patrik Suzzi CLA 2016-08-16 07:06:53 EDT
Requirements: 

1.) Use a new name for "Customize View...", a name that recalls "Filters...". 
- Perhaps we can use "Filters and Customization..."

2.) Package Explorer can remember the last two filters used, and add them as a dynamic menu item with a checkbox. 
- We should do the same for Project Explorer

Adding Mickael in c/c, as ha can give good directions
Comment 9 Ben Tatham CLA 2016-08-16 15:49:42 EDT
Yes, that (comment #8) sounds like what I had in mind.  Just do what the Package Explorer does.
Comment 10 Mickael Istria CLA 2016-08-17 04:32:29 EDT
(In reply to Patrik Suzzi from comment #8)
> 1.) Use a new name for "Customize View...", a name that recalls
> "Filters...". 
> - Perhaps we can use "Filters and Customization..."

Tracked separately in bug 499803. I believe that's a great thing to improve the current menu name.

> 2.) Package Explorer can remember the last two filters used, and add them as
> a dynamic menu item with a checkbox. 
> - We should do the same for Project Explorer

Yes, it's mostly a matter of adding a dynamic menu contribution to the view which adds entry from the 2 last enabled filters.
However, I don't think project explorer keeps in mind which were the 2 last filters enabled/disabled. This would require to store those in the memento (state) of the view.