Bug 499016 - Editor undo granularity is too coarse
Summary: Editor undo granularity is too coarse
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.6   Edit
Hardware: Macintosh Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: needinfo
Depends on:
Blocks:
 
Reported: 2016-08-01 18:31 EDT by Raffi Khatchadourian CLA
Modified: 2020-03-10 12:38 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Raffi Khatchadourian CLA 2016-08-01 18:31:09 EDT
When editing Java code (but perhaps not limited to that), I am finding that the undo granularity is too course. Very frequently, too much work is undone. Is there a way to reduce this granularity to make it finer?


-- Configuration Details --
Product: Eclipse 4.6.0.20160613-1800 (org.eclipse.epp.package.rcp.product)
Installed Features:
 org.eclipse.platform 4.6.0.v20160606-1342
Comment 1 Patrik Suzzi CLA 2016-08-02 05:49:14 EDT
I'm using Eclipse on a Daily basis since a long time, and I feel ok with the undo. I think we need clarifications to understand better what is wrong with the undo: 

- Could you be more precise about what we should improve: autosave after a defined time; autosave after a number of keypresses, etc.. ?
- Is this something specific to Mac, or you know the problem exists also in other distributions? (Linux/Win)

Moving to Eclipse Platform Text, as IUndoManager is defined there.
Comment 2 Patrik Suzzi CLA 2016-08-02 05:52:05 EDT
To be precise: 
- Could you be more precise about what we should improve: autosave after a defined time; autosave after a number of keypresses, etc.. ?

Where, with autosave I mean: saving the current state into the undo stack. 
(and not the new Autosave feature in the IDE)
Comment 3 Raffi Khatchadourian CLA 2016-08-02 10:43:57 EDT
(In reply to Patrik Suzzi from comment #1)
> I'm using Eclipse on a Daily basis since a long time, and I feel ok with the
> undo.

I've also been using Eclipse for a long time (though on and off at times). I have seen this difference in undo functionality beginning with around Mars and now on Neon, perhaps more so.

> I think we need clarifications to understand better what is wrong with
> the undo: 
> 
> - Could you be more precise about what we should improve: autosave after a
> defined time; autosave after a number of keypresses, etc.. ?

For me, it's too course. I'd like smaller undo steps. Perhaps there can be a preference pane to configure this?

> - Is this something specific to Mac, or you know the problem exists also in
> other distributions? (Linux/Win)

That I do not know.
Comment 4 Raffi Khatchadourian CLA 2016-08-02 10:45:15 EDT
(In reply to Patrik Suzzi from comment #2)
> To be precise: 
> - Could you be more precise about what we should improve: autosave after a
> defined time; autosave after a number of keypresses, etc.. ?

It just seems very different from the rest of the other apps on my mac.
Comment 5 Dani Megert CLA 2016-08-03 09:56:30 EDT
(In reply to Raffi Khatchadourian from comment #3)
> (In reply to Patrik Suzzi from comment #1)
> > I'm using Eclipse on a Daily basis since a long time, and I feel ok with the
> > undo.
> 
> I've also been using Eclipse for a long time (though on and off at times). I
> have seen this difference in undo functionality beginning with around Mars
> and now on Neon, perhaps more so.

We didn't change anything in that area. Can you provide an example that allows to see the difference between Neon and pre-Mars?
Comment 6 Raffi Khatchadourian CLA 2016-08-04 10:25:52 EDT
(In reply to Dani Megert from comment #5)
> ...
> 
> We didn't change anything in that area. Can you provide an example that
> allows to see the difference between Neon and pre-Mars?

One thing that seems different is that I can type a lot very quickly but then wait for a while (say almost 1 minute). Now, pressing undo will remove all of those changes. In the past, I don't recall such massive chunks being undone. I'll have to verify this between the two Eclipse versions.
Comment 7 Eclipse Genie CLA 2020-03-10 12:38:38 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.