Bug 498125 - [Task view] Remove unused task view limit constants
Summary: [Task view] Remove unused task view limit constants
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.7 M2   Edit
Assignee: Harald Albers CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted, noteworthy
Depends on: 498056 498127
Blocks:
  Show dependency tree
 
Reported: 2016-07-19 06:53 EDT by Lars Vogel CLA
Modified: 2016-08-19 04:45 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2016-07-19 06:53:52 EDT 
+++ This bug was initially created as a clone of Bug #498056 +++

Bug 498056 increased the limit of displayed items to 1000 and only shows the items for the selected project by default.

We should do the same for the task view.
Comment 1 Lars Vogel CLA 2016-07-19 06:55:30 EDT 
(In reply to Lars Vogel from comment #0)
> +++ This bug was initially created as a clone of Bug #498056 +++

> We should do the same for the task view.

I think for the task view the workspace selection might makes sense. This bug is only for increasing the limit.
Comment 2 Harald Albers CLA 2016-07-21 13:49:00 EDT 
The limit is already set to 1000.

The following settings have no effect and can safely be deleted:

org.eclipse.ui.internal.ide.IDEInternalPreferences.TASKS_LIMIT
org.eclipse.ui.internal.ide.IDEInternalPreferences.LIMIT_TASKS

Adjusting the issue's subject to these findings.
Comment 3 Harald Albers CLA 2016-07-21 13:51:20 EDT 
> Adjusting the issue's subject to these findings.

Apparently I'm no authorized to do so. 
Please consider the subject to be changed to

"Remove unused task view limit constants"
Comment 4 Eclipse Genie CLA 2016-07-21 14:00:22 EDT 
New Gerrit change created: https://git.eclipse.org/r/77710
Comment 5 Lars Vogel CLA 2016-07-21 14:49:33 EDT 
Thanks Harald. Change looks good to me but as I soon leave for vacation and that this _might_ cause issues downstream, I plan to look at that after my vacation. 

If another committer wants to have a look, please feel free.
Comment 6 Harald Albers CLA 2016-07-25 17:02:46 EDT 
There was some confusion about this change: When I created https://git.eclipse.org/r/77710, the value was already changed to 1000.
I changed the issue to a cleanup one.

In the meantime, the setting was reverted to 100 by Lars Vogel, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=498056#c26

So I will change the subject back to its original intent and add another change set that just increases the setting to 1000 again.

The cleanup from https://git.eclipse.org/r/77710 is not affected by this and still remains active.
Comment 7 Eclipse Genie CLA 2016-07-25 17:07:41 EDT 
New Gerrit change created: https://git.eclipse.org/r/77870
Comment 8 Lars Vogel CLA 2016-08-17 08:03:45 EDT 
(In reply to Eclipse Genie from comment #7)
> New Gerrit change created: https://git.eclipse.org/r/77870

This was rejected, without a performance tests that proves that the error view still refreshes. See discussion in https://bugs.eclipse.org/bugs/show_bug.cgi?id=498056
Comment 10 Lars Vogel CLA 2016-08-19 04:45:03 EDT 
Thanks Harald