Community
Participate
Working Groups
I think we should remove the Show items that match all / any configuration below from the Problems View filter. After several years of using Eclipse I still don't understand the use case for match all.
Created attachment 263117 [details] Screenshot
Created attachment 263118 [details] New User Interface Screenshot of the new user interface. Still complex to use but much better IMHO.
New Gerrit change created: https://git.eclipse.org/r/77365
Patrik, what do you think about this change? Does it make the UI more usable?
Lars, those two radio boxes are basically AND and OR operators for the filters below. By removing them you will have only one option - either OR or AND combination, which is not that flexible as before and will be loss of functionality for some power users. The question is - how to make this easier to understand and can we make happy both average/advanced users? I'm definitely advanced user but I *never ever* used a combination of rules. I *always* used a single rule. So I *ALWAYS* deselect "use limits" and "show all" and select "Errors/Warnings on Project" because in my workspace with hundreds of projects and ~30000 warnings my problems view *explodes* and freezes entire Eclipse for seconds if I add or remove a warning in editor. Also I unset limits, because a limit of 100 errors is not useful at all if the *root cause* of all the 100 errors is the 101st error with the project classpath, which is, following Murphy's low, always sorted to the end and not visible... Sad is, that *none* of my co-workers are aware about all of that (and that they can configure Problems view), and so they blame Eclipse for being slow and/or not showing the *right* problem. I see this *every single day*. None of them *ever* tried to configure the Problems view. So what we can do: we should provide simple/advanced configurations choice and offer a "simple" configuration by default. 1) I would enable "Errors/Warnings on Project" rule by default and use it as a base rule for "simple" configuration 2) I would create a new "Configure Contents" dialog, which will be a stripped down version of the current one, and only allows to configure the *single*, selected rule. 3) I would rename the current dialog as "Advanced Configuration". The "Simple" configuration dialog would offer: ----------------------------------------------- (o) Use simple configuration Select rule: [Errors/Warnings on project - default]<combo> [Create new...] Below this combo the panel with the details of the configuration as of today ( ) Use advanced configuration: _Link to the old dialog_ ----------------------------------------------- [ ] Show all items (unchecked by default) [x] Use items limit -> Number of items by group [1000] ----------------------------------------------- I bet that the "average" user will NOT NOTICE ANY CHANGE at all, except that now the Problems view shows problems by project, and that Eclipse doesn't stop on 100 errors anymore but shows up to 1000. And also for average user it would be enough to modify currently selected rule. Also current list of *checkboxes* in the menu of the Problems view should be changed to the "radio" - list in "simple" mode.
Created attachment 263132 [details] Mockup of a "simple" config dialog See the attached mockup for what I'm thinking we should go.
Sounds good with the change of defauts. I was planning to suggest that also soon. Can you create a new bug report for changing these defaults? - Increase limit - Show errors/warnings based on project This will be a big win for the typical user IMHO. But I don't think we need this advanced mode, we should ask on Platform UI mailing list, if someone if using these options and if not reduce the complexity... IMHO less is more in this case.
(In reply to Lars Vogel from comment #7) > Sounds good with the change of defauts. I was planning to suggest that also > soon. Can you create a new bug report for changing these defaults? Created bug 498056. > - Increase limit > - Show errors/warnings based on project > > This will be a big win for the typical user IMHO. > > But I don't think we need this advanced mode, we should ask on Platform UI > mailing list, if someone if using these options and if not reduce the > complexity... > > IMHO less is more in this case. Thinking more about this and bug 498056, one probably can replace the current, exceptionally complicated/over-engineered Problems view configuration with following: 1) Remove the dynamic menu below *entirely*: "Show -> All errors Warnings on Selection Errors/Warnings on Selection Errors/Warnings on Project ... custom entries " 2) Add "Link with Selection" button to the view toolbar. If it is not toggled, we have current "Show All" behavior. If it is toggled, we have "Errors/Warnings based on project" behavior. 3) Simplify "Configure" dialog as suggested in comment 5 to configure the single selected profile, allow to have multiple profiles and select one to be used in that dialog, bit do not offer any and/or combinations etc. I guess/hope nobody uses this anyway.
(In reply to Andrey Loskutov from comment #8) > Warnings on Selection How would like to see the warnings but not the errors on the selection? Created Bug 498059 for that.
(In reply to Andrey Loskutov from comment #8) > but do not offer any and/or combinations etc So you agree that we remove these and/or option? I think a bigger redesign would be useful via a new bug report but I suggest to start with a small step and listen to potential feedback from the community.
Created attachment 263265 [details] Suggested button I always clone the problems view and create one for local problems. I need both, global problem scope and local scope. Global to see if any project has errors, local to pin point it. I think a better solution is to add a button (similar to the one in history), which would narrow down problem view scope when pressed. Attaching screenshot as illustration. Thoughts?
Created attachment 263266 [details] Similar to history I.e, buttons like in history view, but add those to problem view.
(In reply to Leo Ufimtsev from comment #11) > Created attachment 263265 [details] > Suggested button > > I always clone the problems view and create one for local problems. > > I need both, global problem scope and local scope. Global to see if any > project has errors, local to pin point it. > > I think a better solution is to add a button (similar to the one in > history), which would narrow down problem view scope when pressed. > > Attaching screenshot as illustration. > > Thoughts? I create a separate bug for this: Bug 498356 – [problems view] Add buttons to Problem View, to narrow scope https://bugs.eclipse.org/bugs/show_bug.cgi?id=498356 Please post there instead.
Note that bug 498356 also suggests removing most of the options from the dialog. Like comment 8, we'd pretty much agreed that a toolbar button for toggling between "all problems" and "only on selected project" made sense, but it added two additional suggestions: - Add support for filtering by working set. - When you're in the "only on selected project" mode, add a new header row that shows if there are errors in any projects that are hidden by the filter. Expanding this row shows the list of projects with errors and lets you navigate to them. comment 5 describes both why the item limit is a good thing and why our current sort criteria is wrong. In most cases we have enough information to figure out which problem is probably the root cause and should show that problem first, so the user shouldn't need to show and sort through a giant list of problems to locate the root cause. Some useful sort criteria: - show problems in dependencies before problems in dependents - show build path problems before other errors - show "missing class" problems before other errors - show errors in a called class before showing errors in a class that calls it That last criteria is hard for the problems view to compute on its own, but it could probably could be done with assistance of the compiler. The compiler knows about these dependencies and could annotate the problem markers with something that the problems view could later use for sorting.
I know it's unrelated to this, but while we're discussing it: I'd very much like to have the ability to include tasks in the problems view again. This was one of my favorite features in Eclipse 2.1 and I've missed it (and stopped using tasks entirely) ever since it was removed.
I also ask on our mailing list for feedback and there was no disagreement about the removal of the "match all" option. Andrey, Leo and Stefan made further enhancement/ simplification suggestions but I think these should be handled by new bugs. I use this bug for the removal of the "match option."
Gerrit change https://git.eclipse.org/r/77365 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=abc41159dcc7deceecfa06ecbe84e89cff42144d
Only agreement on on the mailing list, so I go ahead and merge this patch. This simplifies the user experience of the problems, bookmark and Tasks view IMHO.
New Gerrit change created: https://git.eclipse.org/r/80024
Gerrit change https://git.eclipse.org/r/80024 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=16ce728b6f617c550761b3049d5ad886b36d6533
New Gerrit change created: https://git.eclipse.org/r/80332
Gerrit change https://git.eclipse.org/r/80332 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=98f4f14987a857d613eb45661f94510c99407e80
*** Bug 497550 has been marked as a duplicate of this bug. ***
The dialog does not match with screenshot in the N&N
(In reply to Sravan Kumar Lakkimsetti from comment #24) > The dialog does not match with screenshot in the N&N I am using M7 candidate build
(In reply to Sravan Kumar Lakkimsetti from comment #25) > I am using M7 candidate build For M7 Markus requested some changes. See Bug 514759 and Bug 514892. Should be update the screenshot for M2 with the changes from M7?
(In reply to Lars Vogel from comment #26) > (In reply to Sravan Kumar Lakkimsetti from comment #25) > > I am using M7 candidate build > > For M7 Markus requested some changes. See Bug 514759 and Bug 514892. Should > be update the screenshot for M2 with the changes from M7? Yes please. It will become easy to create consolidated N&N for Oxygen. Thanks
I reported a problem with this after Oxygen was released. The problem comes when you would like to eliminate more than one thing from the problems list. If you create a text withe "Not Includes" "Foo" and a second one with "Not Includes" "Bar" selecting both of those as filters will essentially negate selecting any of them. I had assumed this would be fixed, but simply eliminating the option of allowing someone to use the existing logic is not really a workable option.
