Bug 497924 - [Welcome] Solstice should trigger generation of doctype so as to guide IE
Summary: [Welcome] Solstice should trigger generation of doctype so as to guide IE
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.6.1   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo
: 490116 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-07-14 12:40 EDT by Sergey Fukanchik CLA
Modified: 2016-08-29 23:41 EDT (History)
5 users (show)

See Also:
psuzzi: neon+
daniel_megert: pmc_approved+
psuzzi: review+


Attachments
Please see the attached screenshot. (80.55 KB, image/png)
2016-07-14 12:40 EDT, Sergey Fukanchik CLA
no flags Details
result of Ctrl-- (73.38 KB, image/png)
2016-07-15 12:30 EDT, Sergey Fukanchik CLA
no flags Details
result of Ctrl-+ (46.08 KB, image/png)
2016-07-15 12:30 EDT, Sergey Fukanchik CLA
no flags Details
output of whatismybrowser.com (187.36 KB, image/png)
2016-07-18 11:59 EDT, Sergey Fukanchik CLA
no flags Details
real browser screenshot (35.59 KB, image/png)
2016-07-18 16:11 EDT, Sergey Fukanchik CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Fukanchik CLA 2016-07-14 12:40:18 EDT
Created attachment 263112 [details]
Please see the attached screenshot.

I donwnloaded eclipse-java-neon-R-win32-x86_64.zip
unpacked it
launched it
created new workspace

see at least two problems:
1. icons are above text making it harder to read
2. Huge word "Eclipse" in header is interfering with the word "Welcome"
Comment 1 Patrik Suzzi CLA 2016-07-14 19:32:51 EDT
Thanks for reporting; 

I cannot reproduce the same exact behavior on Win 10, but I can zoom, pressing Ctrl-+ (Control and plus) reproduce a similar behavior. 

I wonder, what happens if you focus on the browser and press Ctrl+0 (Control and Zero) ? This should reset the browser scaling.
Comment 2 Sergey Fukanchik CLA 2016-07-15 12:29:38 EDT
Hi Patrik,
I tried Ctrl+0. The browser was on normal scale. I also tried Ctrl-+/Ctrl--. It changes scale but doesn't affect position. I am attaching screenshots.

IE version  on my machine is 11.0.9600.18376.

Additionally I switched browser in preferences to Firefox but that didn't help.
Comment 3 Sergey Fukanchik CLA 2016-07-15 12:30:07 EDT
Created attachment 263133 [details]
result of Ctrl--
Comment 4 Sergey Fukanchik CLA 2016-07-15 12:30:25 EDT
Created attachment 263134 [details]
result of Ctrl-+
Comment 5 Patrik Suzzi CLA 2016-07-15 14:33:18 EDT
Adding Brian in c/c as he might be interested
Comment 6 Brian de Alwis CLA 2016-07-17 21:37:10 EDT
I *suspect* you have multiple versions of IE installed and that you're pulling in an older IE rather than IE 11.

Could you please do the following:

  - Ctrl-3 to open the Quick Access
  - type "internal web browser" and open the Internal Web Browser view
  - navigate to https://www.whatismybrowser.com
  - take a screenshot and attach it here

The browser used by the Welcome/Intro is the SWT Browser which embeds a browser widget, and is independent of the Preferences > General > Web Browser setting for external browsers.
Comment 7 Sergey Fukanchik CLA 2016-07-18 11:59:04 EDT
Created attachment 263164 [details]
output of whatismybrowser.com
Comment 8 Brian de Alwis CLA 2016-07-18 13:11:06 EDT
Comment on attachment 263164 [details]
output of whatismybrowser.com

Odd, your browser's user agent is reporting it's IE 7:

> Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.1; Win64; x64; Trident/7.0; .NET CLR 2.0.50727; SLCC2; .NET CLR 3.5.30729; .NET CLR 3.0.30729; InforPath.3; .NET4.0C; .NET4.0E

and the output of that pages looks broken, like it's running on IE 7.

Does it look this broken if you open whatismybrowser.com in IE 11?

You could try using your Add/Remove Programs and verify that you don't have IE 7 (or anything up to 11) installed.
Comment 9 Sergey Fukanchik CLA 2016-07-18 16:10:50 EDT
Yes, https://www.whatismybrowser.com/ looks ok when opened in normal browser and it reports different user agent:
Mozilla/5.0 (Windows NT 6.1; WOW64; Trident/7.0; rv:11.0) like Gecko

As reported from the eclipse:
Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.1; Win64; x64; Trident/7.0; .NET CLR 2.0.50727; SLCC2; .NET CLR 3.5.30729; .NET CLR 3.0.30729; InfoPath.3; .NET4.0C; .NET4.0E)
Comment 10 Sergey Fukanchik CLA 2016-07-18 16:11:17 EDT
Created attachment 263171 [details]
real browser screenshot
Comment 11 Sergey Fukanchik CLA 2016-07-18 16:11:40 EDT
I don't see multiple IEs installed :-(
Comment 12 Sergey Fukanchik CLA 2016-07-18 16:19:23 EDT
So it's compatibility view. Once I add https://www.whatismybrowser.com/ to the compatibility list it starts looking the same as from the Eclipse browser
Comment 13 Brian de Alwis CLA 2016-08-18 11:05:19 EDT
I didn't properly appreciate Sergey's finding.  IE's compat view settings would definitely affect this.  This set of pages in MSDN documents how IE determine the document mode.  It looks like we need to ensure we have a X-UA-Compatible element to be very certain that we're not interpreted in IE7 mode.

https://msdn.microsoft.com/en-us/library/ff405803(v=vs.85).aspx
Comment 14 Eclipse Genie CLA 2016-08-18 11:07:40 EDT
New Gerrit change created: https://git.eclipse.org/r/79274
Comment 15 Brian de Alwis CLA 2016-08-18 11:13:05 EDT
I'm unable to reproduce this using the MS-provided VMs for Win7/IE11 at:

  https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/

Would anybody be able to test this Gerrit change?
Comment 16 Sergey Fukanchik CLA 2016-08-18 12:03:38 EDT
I'm ok to test the change. Where are instructions for testing gerrit changes?
Comment 17 Brian de Alwis CLA 2016-08-18 13:04:06 EDT
Thanks Sergey.  Here's the simplest way I can think of to test:

  1. Open the Gerrit patch link (https://git.eclipse.org/r/79274) and go to Download (upper right) and select Archive > tgz.  That will download a copy of this patch applied to the source.

  2. You'll need an Eclipse with the Plugin Development Environment (PDE).  Start Eclipse with a fresh workspace.

  3. File > Import > Existing Projects and specify the .tgz.  Import all of the projects found.

  4. Use Run > Run As > Eclipse Application

That should run an Eclipse with all of your current plugins, with the patched org.eclipse.ui.intro* plugins.
Comment 18 Sergey Fukanchik CLA 2016-08-19 12:19:05 EDT
My steps:
* Launch oomph eclipse installer
* Select "Eclipse IDE for Eclipse Committers – Neon"
* On the next screen I can see PDE is selected among others
* click Finish
* Once installed - start it with a fresh workspace
* "Import existing projects into workspace"
* select archive I downloaded from https://git.eclipse.org/r/changes/79274/revisions/13c830c52c10111f4e49972e9468bcb3e19b9860/archive?format=tgz
* import all projects

the above process produces the following error dialog:

Some projects cannot be imported because they already exist in the workspace or their project description file is corrupted
  Problems were encountered during import:
    'wbbasicshov_obj.' is an invalid name on this platform.
  Problems were encountered during import:
    'CheatSheetHelpMenuAction.' is an invalid name on this platform.
    'TaskDependencies.' is an invalid name on this platform.
    'DescriptionPanel.' is an invalid name on this platform.
    'ICompositeCheatSheet.' is an invalid name on this platform.
  Problems were encountered during import:
    'IUniversalIntroConstants.' is an invalid name on this platform.
    'UniversalIntroConfigurer.' is an invalid name on this platform.
Comment 19 Brian de Alwis CLA 2016-08-19 12:47:53 EDT
Hmm, that's a bit baffling.  Could you try extracting the archive separately and then importing from a directory?

Really we're just interested in the org.eclipse.ui.intro and org.eclipse.ui.intro.univeral projects.
Comment 20 Sergey Fukanchik CLA 2016-08-19 12:55:27 EDT
Some projects cannot be imported because they already exist in the workspace or their project description file is corrupted
  Problems were encountered during import:
    Error opening input stream for C:\Temp\7\org.eclipse.ua.tests\data\intro\performance\org.eclipse.platform\css\graphics\obj48\wbbasicshov_obj.
  Problems were encountered during import:
    Error opening input stream for C:\Temp\7\org.eclipse.ui.cheatsheets\src\org\eclipse\ui\internal\cheatsheets\actions\CheatSheetHelpMenuAction.
    Error opening input stream for C:\Temp\7\org.eclipse.ui.cheatsheets\src\org\eclipse\ui\internal\cheatsheets\composite\model\TaskDependencies.
    Error opening input stream for C:\Temp\7\org.eclipse.ui.cheatsheets\src\org\eclipse\ui\internal\cheatsheets\composite\views\DescriptionPanel.
    Error opening input stream for C:\Temp\7\org.eclipse.ui.cheatsheets\src\org\eclipse\ui\internal\provisional\cheatsheets\ICompositeCheatSheet.
  Problems were encountered during import:
    Error opening input stream for C:\Temp\7\org.eclipse.ui.intro.universal\src\org\eclipse\ui\internal\intro\universal\IUniversalIntroConstants.
    Error opening input stream for C:\Temp\7\org.eclipse.ui.intro.universal\src\org\eclipse\ui\internal\intro\universal\UniversalIntroConfigurer.



Just these two projects produce this:
Some projects cannot be imported because they already exist in the workspace or their project description file is corrupted
  Problems were encountered during import:
    Error opening input stream for C:\Temp\7\org.eclipse.ui.intro.universal\src\org\eclipse\ui\internal\intro\universal\IUniversalIntroConstants.
    Error opening input stream for C:\Temp\7\org.eclipse.ui.intro.universal\src\org\eclipse\ui\internal\intro\universal\UniversalIntroConfigurer.


the imported projects are all red and launching org.eclipse.ui.intro produces:
!ENTRY org.eclipse.oomph.setup.ui 2 0 2016-08-19 12:53:07.985
!MESSAGE java.lang.NullPointerException
!STACK 0
java.lang.NullPointerException
	at org.eclipse.oomph.setup.ui.SetupUIPlugin.performStartup(SetupUIPlugin.java:379)
	at org.eclipse.oomph.setup.ui.SetupUIPlugin.access$4(SetupUIPlugin.java:350)
	at org.eclipse.oomph.setup.ui.SetupUIPlugin$1$1.run(SetupUIPlugin.java:247)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

welcome screen in this case is shown as simple empty view.
Comment 21 Sergey Fukanchik CLA 2016-08-19 14:39:44 EDT
Together with Brian we were able to verify the fix. Welcome screen looks good now.
Comment 23 Brian de Alwis CLA 2016-08-19 14:50:09 EDT
*** Bug 490116 has been marked as a duplicate of this bug. ***
Comment 24 Brian de Alwis CLA 2016-08-19 14:52:48 EDT
Fixed for 4.7, but leaving open for backport for 4.6.1.  For those who have seen this bug, please tonight's 4.7 nightly build at:

   http://download.eclipse.org/eclipse/downloads/

And thank you Sergey for your help in identifying and verifying the fix.
Comment 25 Eclipse Genie CLA 2016-08-19 15:20:36 EDT
New Gerrit change created: https://git.eclipse.org/r/79375
Comment 26 Sergey Fukanchik CLA 2016-08-25 15:08:58 EDT
The latest integration build fixed the issue for me: http://download.eclipse.org/eclipse/downloads/drops4/I20160823-1359/
Comment 27 Patrik Suzzi CLA 2016-08-27 04:58:07 EDT
Committer +1 for Backport looks on R4_6_maintenance.
Comment 28 Patrik Suzzi CLA 2016-08-27 04:59:04 EDT
Pardon me, I meant: 

Committer +1 for Backport to R4_6_maintenance.
Comment 30 Brian de Alwis CLA 2016-08-28 12:11:22 EDT
Fixed for 4.6.1
Comment 31 Dani Megert CLA 2016-08-29 12:02:59 EDT
NOTE: When you make the first change in a branch you must increase the bundle version. I've done that now in master and R4_6_maintenance.
Comment 32 Brian de Alwis CLA 2016-08-29 12:20:50 EDT
Sorry and thanks.
Comment 33 Brian de Alwis CLA 2016-08-29 23:41:37 EDT
*** Bug 500454 has been marked as a duplicate of this bug. ***