497490 – [CSS] Allign styling of toolbar with perspective switcher for Windows

Bug 497490 - [CSS] Allign styling of toolbar with perspective switcher for Windows

Summary: [CSS] Allign styling of toolbar with perspective switcher for Windows

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.7
Hardware:	PC Windows 7

Importance:	P3 normal (vote)
Target Milestone:	4.6.1
Assignee:	Lars Vogel
QA Contact:

URL:
Whiteboard:
Keywords:	noteworthy

Depends on:	497547
Blocks:
	Show dependency tree

Reported:	2016-07-07 09:38 EDT by Lars Vogel
Modified:	2016-07-19 10:19 EDT (History)
CC List:	3 users (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change Git Commit

Flags:	Lars.Vogel: pmc_approved+ psuzzi: review+

Attachments
Old Styling (115.60 KB, image/png) 2016-07-08 04:51 EDT, Lars Vogel	no flags	Details
New Styling (56.95 KB, image/png) 2016-07-08 04:51 EDT, Lars Vogel	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2016-07-07 09:38:12 EDT

The toolbar of the Windows CSS styling is using a different color than the perspective switcher. This looks broken to me. 

We done similar work for the Mac CSS see https://www.eclipse.org/eclipse/news/4.6/M5/

Comment 1 Eclipse Genie

2016-07-07 09:39:01 EDT

New Gerrit change created: https://git.eclipse.org/r/76856

Comment 2 Lars Vogel

2016-07-08 04:51:43 EDT

Created attachment 262976 [details]
Old Styling

Comment 3 Lars Vogel

2016-07-08 04:51:59 EDT

Created attachment 262977 [details]
New Styling

Comment 4 Dani Megert

2016-07-08 06:12:31 EDT

Sounds good, but only after bug 497547 has been fixed.

Comment 5 Eclipse Genie

2016-07-08 16:11:11 EDT

Gerrit change https://git.eclipse.org/r/76856 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1ea94b37a1db70c872d11973549a1099f5557e2a

Comment 6 Eclipse Genie

2016-07-13 14:53:54 EDT

New Gerrit change created: https://git.eclipse.org/r/77261

Comment 7 Eclipse Genie

2016-07-13 14:57:16 EDT

Gerrit change https://git.eclipse.org/r/77261 was merged to [master].
Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=bb264c1558016693399e2f945827f0917fa147fb

Comment 8 Lars Vogel

2016-07-19 06:21:41 EDT

PMC gave permission to downport this together with the change from Bug 497547.

Comment 9 Lars Vogel

2016-07-19 06:22:18 EDT

(In reply to Lars Vogel from comment #8)
> PMC gave permission to downport this together with the change from Bug
> 497547.

See https://dev.eclipse.org/mhonarc/lists/eclipse-pmc/msg02645.html

Comment 10 Eclipse Genie

2016-07-19 09:23:09 EDT

New Gerrit change created: https://git.eclipse.org/r/77526

Comment 11 Eclipse Genie

2016-07-19 10:13:57 EDT

Gerrit change https://git.eclipse.org/r/77526 was merged to [R4_6_maintenance].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6d5c8ef92e61d6f68a495dc1dc178264c961414f