Bug 497429 - Delete the "run in background" preference and the progress dialog
Summary: Delete the "run in background" preference and the progress dialog
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-06 18:27 EDT by Stefan Xenos CLA
Modified: 2016-08-18 12:59 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Xenos CLA 2016-07-06 18:27:30 EDT 
Extracted from bug 146205.

Now that run in background is enabled by default, it's unlikely that anyone will intentionally use this preference. We should simplify our preference page by removing the option to run in foreground, and simplify our code by removing the preference and dialog box implementation.
Comment 1 Lars Vogel CLA 2016-07-07 02:45:15 EDT 
+1 for removal of this (IMHO useless) preference.

IIRC the dialog is also used if the user clicks on the job indicator, if that is true, we cannot delete it.
Comment 2 Lars Vogel CLA 2016-07-07 09:03:43 EDT 
(In reply to Lars Vogel from comment #1)
> IIRC the dialog is also used if the user clicks on the job indicator, if
> that is true, we cannot delete it.

I'm unable to re-surface the dialog via the UI. I think we can delete it.
Comment 3 Eclipse Genie CLA 2016-07-07 09:06:31 EDT 
New Gerrit change created: https://git.eclipse.org/r/76850
Comment 4 Wim Jongman CLA 2016-07-21 06:18:05 EDT 
Please do not remove the scaffolding for the job progress monitor. I will provide a way to pop it up through API.

I am thinking on providing some addition to Job API where one can request the dialog. If the user presses "always run in background" a callback can inform that the user has selected it which will allow control of it next time around.

I'm back end of august.
Comment 5 Dani Megert CLA 2016-08-18 12:42:23 EDT 
The discussion in bug 146205 shows that several people don't want to run in background. Therefore the preference musts stay.
Comment 6 Stefan Xenos CLA 2016-08-18 12:59:33 EDT 
> The discussion in bug 146205 shows that several people don't want to
> run in background

I'm not sure it shows that. It shows that the current run in background behavior doesn't address their needs. It doesn't necessarily show that retaining this preference would be the best way to address those needs. I think we could draw better conclusions once we understand those needs more concretely.