Bug 497047 - Tags are not getting generated
Summary: Tags are not getting generated
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.7   Edit
Hardware: PC All
: P3 blocker (vote)
Target Milestone: 4.6.1   Edit
Assignee: Sravan Kumar Lakkimsetti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 496335
Blocks:
  Show dependency tree
 
Reported: 2016-06-30 02:18 EDT by Sravan Kumar Lakkimsetti CLA
Modified: 2016-07-08 17:44 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sravan Kumar Lakkimsetti CLA 2016-06-30 02:18:27 EDT
Source code tags are not generated for both M-build and I-build. This needs to be fixed as soon as possible.
Comment 1 Sravan Kumar Lakkimsetti CLA 2016-06-30 03:08:24 EDT
Here is the specific error message I am seeing in the log

08:08:38  Entering 'eclipse.jdt'
08:08:38  Pushing to file:///gitroot/jdt/eclipse.jdt
08:08:39  remote: Can't locate Net/LDAP.pm in @INC (you may need to install the Net::LDAP module) (@INC contains: /usr/lib/perl5/site_perl/5.18.2/x86_64-linux-thread-multi /usr/lib/perl5/site_perl/5.18.2 /usr/lib/perl5/vendor_perl/5.18.2/x86_64-linux-thread-multi /usr/lib/perl5/vendor_perl/5.18.2 /usr/lib/perl5/5.18.2/x86_64-linux-thread-multi /usr/lib/perl5/5.18.2 /usr/lib/perl5/site_perl .) at /home/data/common/eclipse.org-common-ldap.pl line 22.        
08:08:39  remote: BEGIN failed--compilation aborted at /home/data/common/eclipse.org-common-ldap.pl line 22.        
08:08:39  remote: Compilation failed in require at hooks/update line 5.        
08:08:39  remote: error: hook declined to update refs/tags/I20160629-0800        
08:08:39  To file:///gitroot/jdt/eclipse.jdt
08:08:39   ! [remote rejected] I20160629-0800 -> I20160629-0800 (hook declined)
08:08:39  error: failed to push some refs to 'file:///gitroot/jdt/eclipse.jdt'
Comment 2 Sravan Kumar Lakkimsetti CLA 2016-06-30 05:15:00 EDT
There are a lot of comparator errors in the I build. I think this is related to tagging.

http://download.eclipse.org/eclipse/downloads/drops4/I20160629-0800/buildlogs/comparatorlogs/buildtimeComparatorUnanticipated.log.txt
Comment 3 Markus Keller CLA 2016-06-30 09:09:57 EDT
(In reply to Sravan Kumar Lakkimsetti from comment #1)
> 08:08:38  Pushing to file:///gitroot/jdt/eclipse.jdt

I think the problem is that this repo doesn't exist on the filesystem.

Correct url would be:  file:///gitroot/jdt/eclipse.jdt.git
                                                      ^^^^ needs ".git"

Bug 496335 comment 20 says this push was successful, and this includes ".git":
> Pushing to file:///gitroot/platform/eclipse.platform.releng.aggregator.git
Comment 4 Markus Keller CLA 2016-06-30 09:31:22 EDT
(In reply to Markus Keller from comment #3)
That was probably a red herring. https://hudson.eclipse.org/releng/job/I-build/lastBuild/consoleText says it successfully ran ...
> Pushing to file:///gitroot/platform/eclipse.platform.common
... but it failed for ...
> Pushing to file:///gitroot/platform/eclipse.platform

The difference is that the eclipse.platform.common repo does NOT have a hooks/update file, so the perl script that fails in other repos doesn't actually run. eclipse.platform.releng.aggregator.git also misses the hooks/update script. I'll update bug 496335.
Comment 5 Sravan Kumar Lakkimsetti CLA 2016-07-07 04:29:39 EDT
after updating the LDAP module still not able to tag the repos. Here is the error message we are getting

16:06:01  Entering 'eclipse.jdt'
16:06:01  Pushing to file:///gitroot/jdt/eclipse.jdt
16:06:01  fatal: Unable to create '/home/data/git/jdt/eclipse.jdt.git/refs/tags/I20160705-1600.lock': Permission denied
16:06:01  fatal: The remote end hung up unexpectedly
16:06:01  fatal: The remote end hung up unexpectedly

Tags got created for equinox bundles but not created for platform bundles. Looks like permission issue on platform bundles
Comment 6 Sravan Kumar Lakkimsetti CLA 2016-07-07 04:42:40 EDT
@David

I am now how git repo will behave after changing permissions. I suggest recreating the bare-repo using genie.releng id.
Comment 7 Sravan Kumar Lakkimsetti CLA 2016-07-07 04:43:14 EDT
@David

I am not sure how git repo will behave after changing permissions. I suggest recreating the bare-repo using genie.releng id.
Comment 8 Sravan Kumar Lakkimsetti CLA 2016-07-07 07:22:55 EDT
I did some analysis on this. looking at http://build.eclipse.org/eclipse/builds/4I/gitCache/eclipse.platform.releng.aggregator/rt.equinox.framework/bundles/org.eclipse.osgi/target/.apibuild.xml

I found <apitooling.apigeneration projectname="org.eclipse.osgi_3.11.100.v20160630-1447" Here the qualifier mentioned here for release version. I checked qualifier for this package in 4.6 release it is different. I think it is problem with the qualifier. 

The qualifier v20160630-1447 is for June30th build. But we did not had any build on that day(N-build qualifier stats with N). From where this one came?
Comment 9 David Williams CLA 2016-07-07 12:04:51 EDT
(In reply to Sravan Kumar Lakkimsetti from comment #6)
> @David
> 
> I am now how git repo will behave after changing permissions. I suggest
> recreating the bare-repo using genie.releng id.

We dont't need the bare repo recreated ... assuming you mean the one on eclipse.org. 

This "permission problem" is all do to ldap permissions granted to the genie.releng user. 

In come cases, we might need to reclone the build directory, but so far it has done fine. 

Let me know if the difference between those two (or what I am talking about is not clear).
Comment 10 Sravan Kumar Lakkimsetti CLA 2016-07-08 07:46:03 EDT
(In reply to David Williams from comment #9)
> (In reply to Sravan Kumar Lakkimsetti from comment #6)
> > @David
> > 
> > I am now how git repo will behave after changing permissions. I suggest
> > recreating the bare-repo using genie.releng id.
> 
> We dont't need the bare repo recreated ... assuming you mean the one on
> eclipse.org. 
> 
> This "permission problem" is all do to ldap permissions granted to the
> genie.releng user. 
> 
> In come cases, we might need to reclone the build directory, but so far it
> has done fine. 
> 
> Let me know if the difference between those two (or what I am talking about
> is not clear).

What I mean is the bare repo on the build machine. which we access using file:///gitroot. I think we may not need this

this is the error message we are getting
fatal: Unable to create '/home/data/git/jdt/eclipse.jdt.git/refs/tags/I20160705-1600.lock': Permission denied. ther are two sets of permissions one with git level and another at unix permissions. To elimeinate the problem with unix level can you try to create a file at that location?
Comment 11 Markus Keller CLA 2016-07-08 08:39:11 EDT
It is a mystery to me that the push to the rt.equinox.bundles repo succeeded but the push to eclipse.platform.ui failed. getfacl returns pretty similar access rights when I check from build.eclipse.org.

Maybe check the access right from the releng hudson job? Could be that that machine has a different user <-> id mapping.


(In reply to Sravan Kumar Lakkimsetti from comment #8)
> The qualifier v20160630-1447 is for June30th build. But we did not had any
> build on that day(N-build qualifier stats with N). From where this one came?

Bundle qualifiers are generated based on the timestamp of the HEAD commit, not based on the time when the build ran.
Comment 12 David Williams CLA 2016-07-08 17:44:22 EDT
Should be good to go after the server restart in bug 496335 . Sheesh!