Community
Participate
Working Groups
Since MCompositePart inherits from MPart you can add a ToolBar to it. Using the efxclipse renderes the ToolBar is rendered correctly, if the ToolBar is manualy added to the e4xmi. The e4 model editor tooling should allow this feature in the same way it can be done for parts.
Thanks for reporting! Did you check if also the E4 renderer is able to render it correctly ?
I can verify that the efxclipse javafx renderer does it correctly. I don't know about the swt renderer.
Just to mention - just because the SWT-Renderer can't do something does not mean it should not be added.
And supposed the SWT renderer doesn't support it, we should consider adding that support to make the model rendering capabilities even between SWT and JavaFX. @christoph Do you have a simple efxclipse example that shows this? I could try to migrate it to SWT then.
Created attachment 262779 [details] CompositePart Toolbar Demo Project I have attached a project with a Toolbar in a CompositePart that rendes with the efxclipse renderers.
Created attachment 262780 [details] Screenshot of the application And here is a screen shot, so you can see what it should look like.
Any progress on this?
Christoph L., maybe something for you to solve?
New Gerrit change created: https://git.eclipse.org/r/151748
Gerrit change https://git.eclipse.org/r/151748 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/?id=7dfcbcf7c72f6ba45fb7965cfa1e2643cb70f512
Thanks Benedikt for the patch, and Christoph for the review!
Thanks for fixing this, can anyone tell when those changes are release officially? If they are merged to master will they appear in the next Eclipse release?
This will be part of 4.14 in december. It will be part of the next integration build, available tomorrow. Would be great if you could download one and confirm that your issue is solved. https://download.eclipse.org/eclipse/downloads/
(In reply to Karsten Thoms from comment #13) > Would be great if you could download > one and confirm that your issue is solved. I'm not very familiar with the integration build stuff, so maybe you can give me a hint, I tried the following: 1) go to https://download.eclipse.org/eclipse/downloads/ and choose the latest integration build 2) downloaded Eclipse-SDK for my platform, Eclipse starts fine 3) because no RCP Tooling is available, with Windows>Install New Software I only get offered RCPTT 4) next I downloaded the "RCP Runtime Binary" Updatesite, extracted it and add it, but it say "all items installed" .... now I'm a bit stuck :-)
Okay everything is there I was just confused because it seems you cant anymore add a CompositePart to the snippets or controls section, is this intentional? Beside that the Toolbar can now be enabled for a composite Part but it is not rendered by SWT.
Created attachment 280487 [details] CompositePart Toolbar The elements that can be added to the snippets are defined in VSnippetsEditor, there was no change to that class here. If it is intended, one could add it. Same goes for a CompositePart below another CompositePart. This was not possible prior to the commit here, but I am not sure if it should be... I got a toolbar rendered in the PartStack in which the CompositePart resides with SWT, but I had to define a contributing Class for the CompositePart and to make sure that there is a toolbar item defined in the toolbar (see screenshot).
(In reply to Benedikt Kuntz from comment #16) > Created attachment 280487 [details] > CompositePart Toolbar > Thanks it seems thats what need to be done, I noticed that I already opened a request for the Snippets in Bug 551749 so from my point of view this could be closed. (In reply to Benedikt Kuntz from comment #16) > The elements that can be added to the snippets are defined in > VSnippetsEditor, there was no change to that class here. If it is intended, > one could add it. Would be good IMO, do you think you can also create a gerrit for the other bug? What I'm wondering about these "missing elements" is, can't the editor derive the information what are valid element from the EMF Model somewhat, so one won't need to code that manually or is this not possible?
Added a patch set for Bug 551749. From what I've seen so far, there is a lot of redundancy in all those model editor classes, especially when it comes to the handling of adding child elements. I think it would be possible to derive the information from the EMF model, but this would definitely mean a major rework of the whole editor.
(In reply to Benedikt Kuntz from comment #18) > Added a patch set for Bug 551749. Thanks for that I have already reviewed it, but a commiter needs to approve. > I think it would be possible to derive the information from the EMF model, > but this would definitely mean a major rework of the whole editor. I have opened Bug 552639 maybe you can share your investigations there?
