Community
Participate
Working Groups
Created attachment 262629 [details] Plugin with testing view AbstractTreeViewer creates in some cases dummy node (tree item). AbstractTreeViewer.add(Object parentElementOrTreePath, Object childElement) does not handle the dummy node. The dummy node stays in the viewer. If the viewer does not have comparator set, NPE is thrown. java.lang.NullPointerException at org.eclipse.jface.viewers.AbstractTreeViewer.itemExists(AbstractTreeViewer.java:440) at org.eclipse.jface.viewers.AbstractTreeViewer.createAddedElements(AbstractTreeViewer.java:356) at org.eclipse.jface.viewers.AbstractTreeViewer.internalAdd(AbstractTreeViewer.java:281) at org.eclipse.jface.viewers.TreeViewer.internalAdd(TreeViewer.java:630) at org.eclipse.jface.viewers.AbstractTreeViewer.add(AbstractTreeViewer.java:156) at org.eclipse.jface.viewers.AbstractTreeViewer.add(AbstractTreeViewer.java:664) at treeviewer.View.testPressed(View.java:55) at treeviewer.View.access$0(View.java:33) at treeviewer.View$2.widgetSelected(View.java:84) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4353) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1061) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4172) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3761) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1151) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1032) at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:148) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:636) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:579) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:135) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603) at org.eclipse.equinox.launcher.Main.run(Main.java:1465) at org.eclipse.equinox.launcher.Main.main(Main.java:1438) The bug is always reproducable for some cases. I attach plugin with testing view. There are two buttons. One tests viewer with comparator and one test viewer without comparator.
Can the dummy node be disposed when AbstractTreeViewer.add(Object parentElementOrTreePath, Object childElement) is called?
If the comparator is CommonViewerSorter, we get exception: Cannot find navigator content extension (using triggerPoints) for object "<null>" parent path: "com.ataccama.dqc.gui.model.internal.workspace.LocalPurityWorkspaceRoot@ec0c086b". Check that you have an expression for this object in a navigatorContent triggerPoints or enablement. It is because dummy node does not have any data. So null is passed to the CommonViewerSorter. I do not handle this case in the attachement.
Thanks Kamil for the bug report. Can you also provide a fix for the NPE via Gerrit?
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
