Community
Participate
Working Groups
The save icon under Linux Ubuntu 16.04 does look the same in enabled and in disabled mode. Maybe related to the recent icon/ HDPI work?
Screenshots? Scale factor used? Can't reproduce on Windows 7 nor on Ubuntu 14.04.
Created attachment 262127 [details] Animated Gif Animated Gif attached. Watch the editor getting dirty and saved. Save icon remains the same no matter if the editor is dirty or not. No scale factor define via command line, display is a normal laptop display no HDPI.
(In reply to Lars Vogel from comment #2) > Created attachment 262127 [details] > Animated Gif Sorry, dirty indicate cut off. Will upload new gif soon.
Created attachment 262128 [details] Animated Gif now with dirty indicator visible
The animated GIF indeed looks wrong, but I can't reproduce the problem. I don't see an immediate connection to the HiDPI icon work, since that didn't touch any code that deals with disabled icons. Can you check the main menu and see if the Save item text and icon are properly disabled there? What about other buttons in the tool bar that are sometimes disabled (e.g. "Forward", or the "Step *" buttons in the Debug perspective?
(In reply to Markus Keller from comment #5) > Can you check the main menu and see if the Save item text and icon are > properly disabled there? Save menu is correctly enabled/disabled. > What about other buttons in the tool bar that are sometimes disabled (e.g. > "Forward", or the "Step *" buttons in the Debug perspective? The "Terminate" button in the Console view also remains active looking, even if nothing is running. Looks like this bug affects all toolbar items.
(In reply to Markus Keller from comment #5) > The animated GIF indeed looks wrong, but I can't reproduce the problem. > > I don't see an immediate connection to the HiDPI icon work, since that > didn't touch any code that deals with disabled icons. > > Can you check the main menu and see if the Save item text and icon are > properly disabled there? > What about other buttons in the tool bar that are sometimes disabled (e.g. > "Forward", or the "Step *" buttons in the Debug perspective? I can reproduce this on Ubuntu unity 16.04(I did not tried others). One thing I noticed here is only the icon rendered is wrong it renders enabled icon, but the button is not enabled when there are no changes to save.
I just had a look at the Resume button on Ubuntu 12.04 and saw that the disabled version is still slightly colored. But /org.eclipse.debug.ui/icons/full/dlcl16/resume_co.png is grayscale only. org.eclipse.swt.widgets.ToolItem#setDisabledImage(Image) doesn't even pass the disabledImage to the OS, and I don't see an API on GtkToolItems for that. => Looks like GTK or Ubuntu have a bug with rendering disabled GtkToolItems. If gedit has the same problem (check Cut and Copy buttons with an empty selection), then it's NOT_ECLIPSE. Anyway, you should file a bug for GTK.
Lars, is this bug still reproducible?
same here, not only save button but all disabled icons looks the same as enabled. OS: Ubuntu 16.04.2 LTS Eclipse: Version: Neon.3 (4.6.3) Build id: M20170301-0400
Works fine in latest Ubuntu and Eclipse
