Bug 494331 - Workspace Launcher's "Browse" dialog is 10 years out-of-date
Summary: Workspace Launcher's "Browse" dialog is 10 years out-of-date
Status: CLOSED DUPLICATE of bug 443250
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.6   Edit
Hardware: PC Windows All
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
: 188743 (view as bug list)
Depends on: 443250
Blocks:
  Show dependency tree
 
Reported: 2016-05-23 12:50 EDT by Andrew Thomas CLA
Modified: 2017-10-09 02:13 EDT (History)
8 users (show)

See Also:


Attachments
Workspace Launcher's directory chooser dialog (302.78 KB, image/png)
2016-05-23 12:50 EDT, Andrew Thomas CLA
no flags Details
Preferred directory chooser for Windows recommended by Microsoft (30.45 KB, image/png)
2016-05-23 12:52 EDT, Andrew Thomas CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Thomas CLA 2016-05-23 12:50:27 EDT
Created attachment 261958 [details]
Workspace Launcher's directory chooser dialog

The "Workspace Launcher" dialog is kind of important. It's the first thing a user sees when launching an Eclipse IDE. It continues being the first thing seen unless a user checks the box to use the same workspace as a default. 

For new users, this dialog creates a first impression that will color the rest of their experience with Eclipse. For intermediate users, speed of use is important. 

On Windows, the "Browse" button on this dialog leads to a directory chooser that is limited, unfriendly, slow-to-use and out-of-date. 

The old directory chooser suffers from these limitations:
* You can't type or paste any of the path to the desired folder. You're limited to mouse-clicking down a potentially complex and slow folder (and maybe network) hierarchy. 
* Favorites are not provided for fast access.
* No search bar.
* The current value is usually left outside the scroll area, when the dialog first appears. For example, in the attachment, "F:\foo\bar\xyzzy" is selected, but you can't see what's selected. 

Microsoft recommends the newer version beginning with Windows Vista, which was released in 2006. 

http://msdn.microsoft.com/en-us/library/bb762115%28VS.85%29.aspx says:
"For Windows Vista or later, it is recommended that you use IFileDialog with the FOS_PICKFOLDERS option rather than the SHBrowseForFolder function. This uses the Open Files dialog in pick folders mode and is the preferred implementation."


A similar defect has been filed for SWT in general (bug 443250). This defect addresses the significant effect on the Eclipse IDE.
Comment 1 Andrew Thomas CLA 2016-05-23 12:52:08 EDT
Created attachment 261959 [details]
Preferred directory chooser for Windows recommended by Microsoft

This comes from MS Outlook's "Save All Attachments" action. Other examples exist as well.
Comment 2 Lars Vogel CLA 2016-05-23 12:56:13 EDT
(In reply to Andrew Thomas from comment #0)
> A similar defect has been filed for SWT in general (bug 443250). This defect
> addresses the significant effect on the Eclipse IDE.

Once SWT offers a update directory picker, we can use it.
Comment 3 Patrik Suzzi CLA 2016-05-23 13:59:30 EDT
*** Bug 188743 has been marked as a duplicate of this bug. ***
Comment 4 Patrik Suzzi CLA 2016-05-23 14:04:16 EDT
I'm interested in the bug, as I feel losing time with that dir selection dialog : add Installed JRE, add Eclipse Baseline Directory or Target Directory. 

I'm not sure whether this belongs to Platform, JFace or SWT.
Comment 5 Patrik Suzzi CLA 2016-05-23 14:07:42 EDT
(In reply to Patrik Suzzi from comment #4)
> I'm not sure whether this belongs to Platform, JFace or SWT.

I just realized that this bug depends on Bug 443250.
Comment 6 Andrey Loskutov CLA 2016-05-23 14:08:38 EDT
(In reply to Patrik Suzzi from comment #4)
> I'm interested in the bug, as I feel losing time with that dir selection
> dialog : add Installed JRE, add Eclipse Baseline Directory or Target
> Directory. 
> 
> I'm not sure whether this belongs to Platform, JFace or SWT.

SWT. The "right" native widgets must be first contributed by SWT.
Comment 7 Patrick-Jeffrey Pollo Guilbert CLA 2016-10-05 13:34:05 EDT
Adding myself as cc as I do agree that the directory dialog feels really old. Coming from Ubuntu and trying eclipse on Windows I expected the directory dialog showed as attachment but got the non user-friendly old chooser dialog. I am willing to test any patches that could improve that user experience.
Comment 8 Niraj Modi CLA 2017-10-09 02:13:28 EDT
Support for modern directory dialog can be see from Eclipse I20171006-2000 on wards via bug 443250 in SWT.

As expected, above SWT fix also fixed this bug 494331, now we get modern directory dialog in Work-space launcher's view as well, closing this bug.

*** This bug has been marked as a duplicate of bug 443250 ***