Bug 494289 - Menus 'Switch Workspace' and 'Restart' would rather be just above 'Exit'
Summary: Menus 'Switch Workspace' and 'Restart' would rather be just above 'Exit'
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.7 M2   Edit
Assignee: Patrik Suzzi CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2016-05-23 07:11 EDT by Mickael Istria CLA
Modified: 2016-08-15 06:40 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2016-05-23 07:11:41 EDT 
Menus "swich workspace" and "restart" would rather be just above "Exit", since those 3 operations are somewhat related.
Comment 1 Lars Vogel CLA 2016-05-23 07:55:31 EDT 
+1
Comment 2 Eclipse Genie CLA 2016-05-24 05:44:33 EDT 
New Gerrit change created: https://git.eclipse.org/r/73453
Comment 3 Patrik Suzzi CLA 2016-05-24 05:45:58 EDT 
For the Restart, is enough setting the locationURI="menu:file?before=quit". See attached change, and visual result here: http://i.imgur.com/zuzJTfb.png .

But for the "Switch Workspace" is harder, as the menu is not defined via XML, but programmatically, in the class OpenWorkspaceAction:
The constructor, OpenWorkspaceAction(.) sets "Open &Worskspace" as text,
and the inner class OpenDialogAction defines the MenuItem "Open Workspace > Other..."

Do you have any hint/reference on how to complete this?
Comment 4 Lars Vogel CLA 2016-07-19 09:19:45 EDT 
(In reply to Patrik Suzzi from comment #3)
> Do you have any hint/reference on how to complete this?

Several actions are just wrapper around a command. Maybe convert it to a command, wrap it in the action and only add it to the menu via the command?
Comment 5 Patrik Suzzi CLA 2016-07-19 12:28:41 EDT 
With the updated change, both Switch Workspace and Restart are above the Exit menu Item. 

I did not create a new command, but I could do if it's the recommended way. 

please, see how it looks: http://i.imgur.com/j3o8pFa.png
Comment 6 Lars Vogel CLA 2016-07-19 14:34:01 EDT 
Should we add a separator before exit?
Comment 7 Dani Megert CLA 2016-08-10 10:10:49 EDT 
M1 is done. Moving to M2.
Comment 8 Patrik Suzzi CLA 2016-08-10 12:44:32 EDT 
With the latest change, I added a separator, that will be hidden on Mac, as it happens for the Menu

see how it looks on PC: http://i.imgur.com/ctd56q4.png
and this is how it looks on Mac: http://i.imgur.com/UOJrD6P.png
Comment 10 Dani Megert CLA 2016-08-11 12:34:34 EDT 
There separator between Restart and Exit should be removed, see e.g. Firefox.
Comment 11 Patrik Suzzi CLA 2016-08-11 12:42:12 EDT 
Fixing shortly
Comment 12 Eclipse Genie CLA 2016-08-11 12:50:54 EDT 
New Gerrit change created: https://git.eclipse.org/r/78888
Comment 13 Patrik Suzzi CLA 2016-08-11 13:15:09 EDT 
With the latest change, the menu is as requested. Please, see linked images. 

- Win: http://i.imgur.com/ctd56q4.png
- Linux: http://i.imgur.com/XQDbvCa.png
- Mac: http://i.imgur.com/lncALJn.png
Comment 14 Patrik Suzzi CLA 2016-08-11 13:16:54 EDT 
Sorry, in the comment above, the first link is wrong. 

Below you can see the correct images:

- Win: http://i.imgur.com/Sb1O8Si.png
- Linux: http://i.imgur.com/XQDbvCa.png
- Mac: http://i.imgur.com/lncALJn.png
Comment 16 Patrik Suzzi CLA 2016-08-11 13:20:50 EDT 
Fixed for M2
Comment 17 Lars Vogel CLA 2016-08-15 00:53:12 EDT 
(In reply to Patrik Suzzi from comment #16)
> Fixed for M2

Thanks. Please add a small N&N entry for this.
Comment 18 Eclipse Genie CLA 2016-08-15 05:43:29 EDT 
New Gerrit change created: https://git.eclipse.org/r/79036