Bug 494183 - [GTK3.22] Small sizes in ControlExample and "underallocate" warnings in console
Summary: [GTK3.22] Small sizes in ControlExample and "underallocate" warnings in console
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.6   Edit
Hardware: PC Linux
: P2 major (vote)
Target Milestone: 4.7 M1   Edit
Assignee: Ian Pun CLA
QA Contact:
URL:
Whiteboard:
Keywords: greatfix, noteworthy
Depends on:
Blocks:
 
Reported: 2016-05-20 10:47 EDT by Eric Williams CLA
Modified: 2016-07-29 09:59 EDT (History)
3 users (show)

See Also:


Attachments
Small widget sizes on GTK3.21 (157.52 KB, image/png)
2016-05-20 10:47 EDT, Eric Williams CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Williams CLA 2016-05-20 10:47:36 EDT
Created attachment 261902 [details]
Small widget sizes on GTK3.21

Some new bugs for the latest development version of GTK3, looking ahead to Fedora 25.

Launching ControlExample using GTK3.21 shows small widget sizes, with "underallocate" warnings in console:

: Gtk-WARNING **: gtk_widget_size_allocate(): attempt to underallocate SwtFixed's child GtkScrolledWindow 0x7f4b2a5e82f0. Allocation is 61x62, but minimum required size is 61x86.

(SWT:19188): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to underallocate GtkScrolledWindow's child GtkScrollbar 0x7f4b2a5eb9a0. Allocation is 13x22, but minimum required size is 13x46.


See the attached screenshot.
Comment 1 Eclipse Genie CLA 2016-06-23 11:37:14 EDT
New Gerrit change created: https://git.eclipse.org/r/75861
Comment 2 Leo Ufimtsev CLA 2016-07-20 09:48:29 EDT
Hello Ian, 

There was talk about this being a Gtk issue of sorts and that you created a bug in Gtk Bugzilla, would you be able to post a link? 

~ Also increasing priority/severity as Eclipse is very unusable without this bugfix on newest Gtk Versions.
Comment 3 Ian Pun CLA 2016-07-20 10:38:27 EDT
Bug reported here:

https://bugzilla.gnome.org/show_bug.cgi?id=768925

Waiting for a reply on this. I have had a small discussion over #GTK+ about it but was referred to post a bug on it.
Comment 4 Leo Ufimtsev CLA 2016-07-27 12:17:11 EDT
As Ian/Eric pointed out in the meeting, a related bug was submitted in the GTK bugrilla:
https://bugzilla.gnome.org/show_bug.cgi?id=768902
Comment 5 Eric Williams CLA 2016-07-28 13:47:43 EDT
This has been fixed upstream in GTK:

https://github.com/GNOME/gtk/commit/5ccc0e40f5eaa9c0e2121674913c398e9963f0be

The changes will be in the next 3.21.x release and also in 3.22.
Comment 6 Leo Ufimtsev CLA 2016-07-29 09:59:39 EDT
(In reply to comment #5)
> This has been fixed upstream in GTK:
> 
> https://github.com/GNOME/gtk/commit/5ccc0e40f5eaa9c0e2121674913c398e9963f0be
> 
> The changes will be in the next 3.21.x release and also in 3.22.

Kudos to Eric and Ian for working on this, that is motivating Gtk folks, testing and modifying their patch. 
It was pretty hard to use Eclipse with small fonts, now it's well again.

Thank you for your efforts.