Community
Participate
Working Groups
4.6 RC1 Bug459961Test.testTransparentColorConstantReference consistently fails on CentOs http://download.eclipse.org/eclipse/downloads/drops4/I20160512-1000/testresults/html/org.eclipse.e4.ui.tests.css.swt_ep46I-unit-cen64_linux.gtk.x86_64_8.0.html expected:<255> but was:<237> java.lang.AssertionError: expected:<255> but was:<237> at org.eclipse.e4.ui.tests.css.swt.Bug459961Test.assertRGBAEquals(Bug459961Test.java:46) at org.eclipse.e4.ui.tests.css.swt.Bug459961Test.testTransparentColorConstantReference(Bug459961Test.java:42) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:743) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:351) at org.eclipse.test.CoreTestApplication.runTests(CoreTestApplication.java:36) at org.eclipse.test.CoreTestApplication.run(CoreTestApplication.java:32) at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethodWithException(EclipseAppContainer.java:587) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:198) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610) at org.eclipse.equinox.launcher.Main.run(Main.java:1519) at org.eclipse.equinox.launcher.Main.main(Main.java:1492) at org.eclipse.core.launcher.Main.main(Main.java:34)
Moving out of Neon. If you still want to fix something during RC3 then please retarget and make sure you follow the rules: https://www.eclipse.org/eclipse/development/plans/freeze_plan_4_6.php#FixPassAfterRC2
(In reply to Dani Megert from comment #1) > Moving out of Neon. If you still want to fix something during RC3 then > please retarget and make sure you follow the rules: > https://www.eclipse.org/eclipse/development/plans/freeze_plan_4_6.php#FixPassAfterRC2 > Let's disable this test until we have a fix. +1 for RC3.
I will check this. I am suspecting a configuration issue rather than a bug in this case. If it is indeed a configuration issue we may need to change the test.
(In reply to Dani Megert from comment #2) > (In reply to Dani Megert from comment #1) > > Moving out of Neon. If you still want to fix something during RC3 then > > please retarget and make sure you follow the rules: > > https://www.eclipse.org/eclipse/development/plans/freeze_plan_4_6.php#FixPassAfterRC2 > > > > Let's disable this test until we have a fix. > > +1 for RC3. Here is the root cause. the Adwaita theme uses a different color than the standard color for background. Expected color is extracted using COLOR_TRANSPARENT(SWT default color 255,255,255,0 not theme aware) Actual color is extracted from the background color from the theme currently in use. In this case Adwaita theme and in AdWaita the bg color is defined as 237,237,237. Now the test is failing while comparing RGB. There are two ways to fix 1. Change the expected color to SWT.COLOR_WIDGET_BACKGROUND(css based theme aware color) 2. Since the test is about verifying the transparency we can check only alpha value instead of RGBA. Please suggest which way to proceed. I prefer the first approach
(In reply to Sravan Kumar Lakkimsetti from comment #4) > (In reply to Dani Megert from comment #2) > > (In reply to Dani Megert from comment #1) > > > Moving out of Neon. If you still want to fix something during RC3 then > > > please retarget and make sure you follow the rules: > > > https://www.eclipse.org/eclipse/development/plans/freeze_plan_4_6.php#FixPassAfterRC2 > > > > > > > Let's disable this test until we have a fix. > > > > +1 for RC3. > > Here is the root cause. the Adwaita theme uses a different color than the > standard color for background. > > Expected color is extracted using COLOR_TRANSPARENT(SWT default color > 255,255,255,0 not theme aware) > Actual color is extracted from the background color from the theme currently > in use. In this case Adwaita theme and in AdWaita the bg color is defined as > 237,237,237. > > Now the test is failing while comparing RGB. There are two ways to fix > > 1. Change the expected color to SWT.COLOR_WIDGET_BACKGROUND(css based theme > aware color) > 2. Since the test is about verifying the transparency we can check only > alpha value instead of RGBA. > > Please suggest which way to proceed. I prefer the first approach Option 1. sounds better to me, better to compare the actual color.
(In reply to Alexander Kurtakov from comment #5) > Option 1. sounds better to me, better to compare the actual color. +1
New Gerrit change created: https://git.eclipse.org/r/73358
Hi Alex and Lars, Can you please review the patch so that we can push it for RC3? Thanks Sravan
Opened SWT bug to track this in 4.7
+1 for RC3, change looks good
(In reply to Sravan Kumar Lakkimsetti from comment #9) > Opened SWT bug to track this in 4.7 See Bug 494327
Alex has commented that the code change fails on GTK 3.20. Now the option I have is to disable the test. I will upload a patch to disable the test shortly
Alex, Lars and Dani I have disabled the test for GTK3 for Neon. Can you please review the change again? Thanks
Gerrit change https://git.eclipse.org/r/73358 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=38b6cf93e508288ec49a2de674115aaaeb4008a5
This is just a change in the tests and does not require 3 +1s.
Verified in eclipse-SDK-I20160525-2000-win32-x86_64.
