Bug 493589 - [GTK3] Toolbars, editor tabs, status line way too large under KDE
Summary: [GTK3] Toolbars, editor tabs, status line way too large under KDE
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.6   Edit
Hardware: PC Linux
: P3 normal with 2 votes (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 493712 494247 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-05-12 18:28 EDT by Sergey Prigogin CLA
Modified: 2017-12-14 18:30 EST (History)
11 users (show)

See Also:

Attachments
Eclipse toolbar with GTK3 under KDE (9.36 KB, image/png)
2016-05-12 18:28 EDT, Sergey Prigogin CLA 		no flags Details
Eclipse toolbar with GTK2 under KDE (8.87 KB, image/png)
2016-05-12 18:29 EDT, Sergey Prigogin CLA 		no flags Details
GTK3 under Unity - sizes are normal (6.62 KB, image/png)
2016-05-12 18:31 EDT, Sergey Prigogin CLA 		no flags Details
GTK3 under Cinnamon - sizes are normal (8.39 KB, image/png)
2016-05-12 18:32 EDT, Sergey Prigogin CLA 		no flags Details
Eclipse vs gedit (25.25 KB, image/png)
2016-05-12 18:34 EDT, Sergey Prigogin CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Prigogin CLA 2016-05-12 18:28:16 EDT 
Created attachment 261704 [details]
Eclipse toolbar with GTK3 under KDE

Eclipse SDK 4.6.0.I20160506-1030
Ubuntu 14.04.1
KDE 4.13.3
GTK 3.10.8
Desktop theme: Oxygen (same behavior in Klassik)

Under Unitity and Cinnamon the sizes are OK.
Comment 1 Sergey Prigogin CLA 2016-05-12 18:29:05 EDT 
Created attachment 261705 [details]
Eclipse toolbar with GTK2 under KDE
Comment 2 Sergey Prigogin CLA 2016-05-12 18:31:22 EDT 
Created attachment 261706 [details]
GTK3 under Unity - sizes are normal
Comment 3 Sergey Prigogin CLA 2016-05-12 18:32:09 EDT 
Created attachment 261707 [details]
GTK3 under Cinnamon - sizes are normal
Comment 4 Sergey Prigogin CLA 2016-05-12 18:34:43 EDT 
Created attachment 261708 [details]
Eclipse vs gedit

Eclipse toolbar has extra vertical margin compared to gedit. Given that Eclipse toolbar icons are smaller than the gedit ones, the toolbar should be smaller accordingly. It looks like the toolbar is sized based not on the icon size, but on something else.
Comment 5 Andrey Loskutov CLA 2016-05-15 14:20:22 EDT 
*** Bug 493712 has been marked as a duplicate of this bug. ***
Comment 6 Linuxhippy CLA 2016-05-15 14:25:07 EDT 
The report Bug 493712 was marked as duplicate although I was running XFCE and not KDE. Could the title of this bug please be changed, to reflect this is not an issue specific to KDE only?
Comment 7 Arun Thondapu CLA 2016-05-15 16:26:25 EDT 
I'd rather we don't include all non Gnome desktops because Unity and Cinnamon don't seem to exhibit the problem that is currently seen on KDE/XFCE.
Comment 8 Linuxhippy CLA 2016-05-15 16:46:57 EDT 
sorry, my report is invalid - i was actually testing 4.5.2.
with 4.6M7 toolbars are layouted as expected when running xfce.
Comment 9 Patrik Suzzi CLA 2016-06-01 12:30:09 EDT 
*** Bug 494247 has been marked as a duplicate of this bug. ***
Comment 10 Arun Thondapu CLA 2016-11-21 13:01:49 EST 
Moving to 4.7, can be backported to 4.6.3 if it gets fixed in master by then...
Comment 11 Andrey Loskutov CLA 2016-11-21 17:50:19 EST 
See also bug 507604 for GTK 3.14, where the first patch allows you to further reduce the padding by providing a custom CSS, and second patch does this by default.
Comment 12 Sergey Prigogin CLA 2016-11-21 18:55:50 EST 
(In reply to Andrey Loskutov from comment #11)
Unfortunately, it would not work for GTK 3.10.8 that we are using. Is there a way to make it work for GTK 3.10?
Comment 13 Alexander Kurtakov CLA 2017-02-16 00:34:56 EST 
(In reply to Sergey Prigogin from comment #12)
> (In reply to Andrey Loskutov from comment #11)
> Unfortunately, it would not work for GTK 3.10.8 that we are using. Is there
> a way to make it work for GTK 3.10?

Not an easy one. I would say whoever wants to work on that old Gtk version would have to put a lot of effort and stability would probably not be a thing too.
Comment 14 Arun Thondapu CLA 2017-05-25 15:44:07 EDT 
Moving out of 4.7.
Comment 15 Alexander Kurtakov CLA 2017-12-14 18:30:00 EST 
Closing the bug as wontfix. In case someone plans working on it please reopen.