Description Willy Michel 2016-05-12 09:39:15 EDT

Created attachment 261692 [details]
Custom perspective

Steps to reproduce:
- Start Eclipse IDE
- Right-click the toolbar button of any perspective (e.g. "Debug")
- Select "Save As..."
- Use the '.' character in the name of new perspective (e.g. "My.Debug")
- Close the dialog with "OK"
- The button of the new custom perspective is shown in the toolbar correctly (with the right icon)
- Restart Eclipse IDE
- The button of the new custom perspective is shown in the toolbar but with the default perspective icon

The reason is in the PerspectiveRegistry and this methods:

private String createNewId(String label, PerspectiveDescriptor riginalDescriptor) {
   return originalDescriptor.getOriginalId() + '.' + label;
}

private String getOriginalId(String id) {
   int index = id.lastIndexOf('.');
   if (index == -1)
      return id;
   return id.substring(0, index);
}

If you save a new perspective, then the name you typed will be used to create the perspective ID. On the other side, while loading the perspective from the workspace, the "originalID" will be exctracted from the custom perspective ID. So if you have a '.' character in the perspective name, it will be truncated at the wrong location:

Custom perspective ID: "org.eclipse.debug.ui.DebugPerspective.My.Debug" ->
Original perspective ID: "org.eclipse.debug.ui.DebugPerspective.My"

Since there is no original perspective with such ID, you custom perspective has no parent and doesn't get any icon (therefore the default icon is shown).