Bug 493478 - Detached views and editors are broken on GTK 2
Summary: Detached views and editors are broken on GTK 2
Status: CLOSED DUPLICATE of bug 493477
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: PC Linux
: P2 major (vote)
Target Milestone: 4.6 RC2   Edit
Assignee: Stefan Xenos CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 493477
Blocks:
  Show dependency tree
 
Reported: 2016-05-11 22:56 EDT by Stefan Xenos CLA
Modified: 2016-05-18 14:45 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Xenos CLA 2016-05-11 22:56:20 EDT 
Running on GTK 2, it is no longer possible to detach (or reattach) views or editors using drag-and-drop.

This was introduced by bug 492842, which fixed GTK 3. Unfortunately, thanks to bug 493477 and bug 492783, there is no single approach that will work on all platforms.

The best workaround for 4.6 is probably to check the GTK version and use a different Tracker constructor based on whether bug 493477 or bug 492783 needs to be worked around.
Comment 1 Eclipse Genie CLA 2016-05-11 23:36:56 EDT 
New Gerrit change created: https://git.eclipse.org/r/72589
Comment 2 Stefan Xenos CLA 2016-05-12 00:12:02 EDT 
I've attached an alternative fix (for the SWT layer) to bug 493477.

I've tested the patch attached here on both GTK 2 and GTK 3. I haven't tested the patch for bug 493477 yet.
Comment 3 Stephan Herrmann CLA 2016-05-12 14:40:44 EDT 
(In reply to Stefan Xenos from comment #0)
> Running on GTK 2, it is no longer possible to detach (or reattach) views or
> editors using drag-and-drop.

Is it still possible to use RC1-on-GTK2 on a workspace that already has a window layout with detached views?
Comment 4 Stefan Xenos CLA 2016-05-12 15:08:23 EDT 
> Is it still possible to use RC1-on-GTK2 on a workspace that already has
> a window layout with detached views?

You can use it. You just can't reattach the views without resetting the perspective and you can't detach additional views.
Comment 5 Stefan Xenos CLA 2016-05-12 16:02:59 EDT 
I've got a fix for the SWT issue attached to bug 493477.

I've removed the workaround.
Comment 6 Dani Megert CLA 2016-05-18 13:19:45 EDT 
Moving out of Neon. If you still want to fix something during RC3 then please retarget and make sure you follow the rules: https://www.eclipse.org/eclipse/development/plans/freeze_plan_4_6.php#FixPassAfterRC2
Comment 7 Stefan Xenos CLA 2016-05-18 13:35:18 EDT 
This was fixed by the fix to bug 493477.
Comment 8 Dani Megert CLA 2016-05-18 14:45:43 EDT 
.

*** This bug has been marked as a duplicate of bug 493477 ***