Bug 493299 - Use varargs in package org.eclipse.jface.text.source.JFaceTextMessages.getFormattedString
Summary: Use varargs in package org.eclipse.jface.text.source.JFaceTextMessages.getFor...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.8 M1   Edit
Assignee: Marlo Häring CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2016-05-10 04:57 EDT by Lars Vogel CLA
Modified: 2017-07-18 04:43 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2016-05-10 04:57:06 EDT 

    


    


      



        
          Comment 1
        

        
          Lars Vogel CLA

        

        
        

        
          2017-07-13 18:08:30 EDT
        

      






We should adjust the method to public static String getFormattedString(String key, Object... args) and adjust callers.

    


    


      



        
          Comment 2
        

        
          Dani Megert CLA

        

        
        

        
          2017-07-14 04:02:18 EDT
        

      






(In reply to Lars Vogel from comment #1)
> We should adjust the method to public static String
> getFormattedString(String key, Object... args) and adjust callers.

No, it must not become public. Platform Text (and also JDT) manages NLS strings per package.

    


    


      



        
          Comment 3
        

        
          Lars Vogel CLA

        

        
        

        
          2017-07-14 04:12:19 EDT
        

      






(In reply to Dani Megert from comment #2)
> (In reply to Lars Vogel from comment #1)
> > We should adjust the method to public static String
> > getFormattedString(String key, Object... args) and adjust callers.
> 
> No, it must not become public. Platform Text (and also JDT) manages NLS
> strings per package.

The method signature was copied from existing code, only new thing is Object... instead of Object[]

    


    


      



        
          Comment 4
        

        
          Dani Megert CLA

        

        
        

        
          2017-07-14 04:24:49 EDT
        

      






(In reply to Lars Vogel from comment #3)
> (In reply to Dani Megert from comment #2)
> > (In reply to Lars Vogel from comment #1)
> > > We should adjust the method to public static String
> > > getFormattedString(String key, Object... args) and adjust callers.
> > 
> > No, it must not become public. Platform Text (and also JDT) manages NLS
> > strings per package.
> 
> The method signature was copied from existing code, only new thing is
> Object... instead of Object[]

OOps, I was looking at the class itself, which must remain package visible. The method is fine.

    


    

    


      



        
          Comment 6
        

        
          Alexander Kurtakov CLA

        

        
        

        
          2017-07-18 04:43:43 EDT
        

      






In master now.