Community
Participate
Working Groups
4.5 and beyond Customize Perspective dialog: items on '' tab must not be rendered in disabled color.
This got broken by fix for bug 420956.
Fix should be trivial.
Dani, there are 3 columns on this page: left one for "Available action sets", middle one for "Menubar details", right one for "Toolbar details". All three render unavailable elements in "disabled" color. I guess you only want the left one to show all elements in standard color?
New Gerrit change created: https://git.eclipse.org/r/72232
New Gerrit change created: https://git.eclipse.org/r/72231
Created attachment 261537 [details] Fix for the left column only (In reply to Eclipse Genie from comment #4) > New Gerrit change created: https://git.eclipse.org/r/72232 (In reply to Eclipse Genie from comment #5) > New Gerrit change created: https://git.eclipse.org/r/72231 Dani, please chose which one you want, if you meant all 3 columns, then we need both patches, if you meant only the left column, we need only patch 72231 (this is what the attached picture shows).
*** Bug 492662 has been marked as a duplicate of this bug. ***
I think he means just the first column (the "Available action sets"). Having the Menu and Toolbar columns controlled by the check state makes sense. So +1 to 72231 from me.
(In reply to Andrey Loskutov from comment #6) > Dani, please chose which one you want, if you meant all 3 columns, then we > need both patches, if you meant only the left column, we need only patch > 72231 (this is what the attached picture shows). I was talking about the whole entry/line. Let me know if that is not obvious.
(In reply to Dani Megert from comment #9) > (In reply to Andrey Loskutov from comment #6) > > Dani, please chose which one you want, if you meant all 3 columns, then we > > need both patches, if you meant only the left column, we need only patch > > 72231 (this is what the attached picture shows). > > I was talking about the whole entry/line. Let me know if that is not obvious. Dani, wjat do you mean by a "line"? Does attached picture (patch 72231) shows what you expect or not? If not, we need both patches. Could you then please add your +1 on appropriate patch(es) and here on the bug, if you want it for RC1?
Gerrit change https://git.eclipse.org/r/72231 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0277b09528f8d95c3a353ffa9e1dc9e5ae23d6cd
(In reply to Andrey Loskutov from comment #10) > (In reply to Dani Megert from comment #9) > > (In reply to Andrey Loskutov from comment #6) > > > Dani, please chose which one you want, if you meant all 3 columns, then we > > > need both patches, if you meant only the left column, we need only patch > > > 72231 (this is what the attached picture shows). > > > > I was talking about the whole entry/line. Let me know if that is not obvious. > > Dani, wjat do you mean by a "line"? Does attached picture (patch 72231) > shows what you expect or not? Yes. I never thought about the other two columns, since they are correctly enabled depending on the checkbox. Thanks for the fix!
Verified in eclipse-SDK-I20160511-2000-win32-x86_64.