Bug 4931 - [CVS Sync View] Compare usability: Should show first difference on open
Summary: [CVS Sync View] Compare usability: Should show first difference on open
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.0 M8   Edit
Assignee: Jean-Michel Lemieux CLA
QA Contact:
URL:
Whiteboard:
Keywords: investigate
: 46243 47635 (view as bug list)
Depends on:
Blocks:
 
Reported: 2001-10-12 11:09 EDT by Jerome Lanneluc CLA
Modified: 2004-03-22 09:56 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2001-10-12 11:09:19 EDT 
When comparing a compilation unit with the content of the team stream, you have 
to select the only version of the CU in the structure compare, it selects the 
whole line of the first difference, then you have to press the down arrow once 
to see the change and this difference is not centered.

So there are several problems here:
1. The structure compare has no value since it is supposed to show several 
versions and there will ever be one (since you're comparing against the stream 
version).
2. Showing the entire line doesn't show the difference, you have to do one more 
action to get it.
3. You have to scroll horizontally twice to see the difference.
Comment 1 Andre Weinand CLA 2002-01-22 03:56:13 EST 
I cannot fix 1) since that is VCM.
2.) The compare's model of showing differences is always:
    - show the range of lines
    - if you want to see detailed changes within a line you
      have to press an action
3.) horizontal revealing is fixed

Assigned to VCM because of 1)
Comment 2 Andre Weinand CLA 2002-01-22 03:56:59 EST 
I cannot fix 1) since that is VCM.
2.) The compare's model of showing differences is always:
    - show the range of lines
    - if you want to see detailed changes within a line you
      have to press an action
3.) horizontal revealing is fixed

Assigned to VCM because of 1)
Comment 3 Kevin McGuire CLA 2002-06-06 12:17:49 EDT 
post 2.0
Comment 4 Michael Valenta CLA 2002-09-08 19:39:45 EDT 
Reopening
Comment 5 Michael Valenta CLA 2002-09-08 19:41:24 EDT 
Should test to see if this is still an issue.
Comment 6 Jean-Michel Lemieux CLA 2003-06-16 14:26:43 EDT 
The new sync view compare input solves this problem but we should propagate to
CVS. This would require changing the compare with remote action so that it is
smarter when only one file is selected to compare. There is no need to show the
structure compare in that case.
Comment 7 Jean-Michel Lemieux CLA 2003-08-19 10:14:44 EDT 
No time in M3.
Comment 8 Jean-Michel Lemieux CLA 2003-11-06 21:09:06 EST 
*** Bug 46243 has been marked as a duplicate of this bug. ***
Comment 9 Jean-Michel Lemieux CLA 2003-11-27 10:56:20 EST 
*** Bug 47635 has been marked as a duplicate of this bug. ***
Comment 10 Jean-Michel Lemieux CLA 2004-02-27 21:54:18 EST 
This is fixed now > I20030226.
Basically compare with remote is shown in the sync view and is always up-to-date
for outgoing changes. Opening a compare editor on a file shows you only that file.
Comment 11 Michael Valenta CLA 2004-03-15 12:17:11 EST 
Verified. When run on a single file selection, Compare with Latest and Compare 
with Tag both launch a compare editor on that file.
Comment 12 Jared Burns CLA 2004-03-18 03:13:01 EST 
This doesn't work in the 20040317 build (in Win2K, at least).

1. Show the CVS Resource History of a file.
2. Select two revisions.
3. Right click -> Compare.
4. The compare editor opens, but the file contents are shown (same behavior as 
always). The only difference is that my cursor changes to a busy cursor 
permanently inside Eclipse. I can still use the cursor, but its stuck as an 
hourglass at this point.
Comment 13 Jean-Michel Lemieux CLA 2004-03-22 09:56:10 EST 
The busy cursor will actually reset but it seems to have a fixed time it stays
busy, see ui bug 55521.

Comparing two remote files hasn't currently been fixed yet see bug 55524.