Bug 493078 - CoolBar layout improvement
Summary: CoolBar layout improvement
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2016-05-05 08:48 EDT by Patrik Suzzi CLA
Modified: 2017-05-24 11:18 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrik Suzzi CLA 2016-05-05 08:48:17 EDT 
According to comments in Bug 492974 and to comments on related change 72108/1 (#1), we should re-design the layout of the CoolBar, to be independent of its size. 

In particular, I refer to the comment about ToolBarManager#relayout(ToolBar, int, int), that should work if we just delete the body and replace it with a single call to layoutBar.requestLayout()

Hence, we should fix CoolBar layout to use the computed size of its children directly. 

See:
#1 https://git.eclipse.org/r/#/c/72108/1/bundles/org.eclipse.jface/src/org/eclipse/jface/action/ToolBarManager.java