493037 – [api] change task list externalization to use SAX instead of DOM

Bug 493037 - [api] change task list externalization to use SAX instead of DOM

Summary: [api] change task list externalization to use SAX instead of DOM

Status:	RESOLVED FIXED

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	Mylyn (show other bugs)
Version:	3.19
Hardware:	PC Windows 7

Importance:	P3 enhancement (vote)
Target Milestone:	3.20
Assignee:	Jaxsun McCarthy Huggan
QA Contact:

URL:
Whiteboard:
Keywords:	noteworthy

Depends on:
Blocks:

Reported:	2016-05-04 19:53 EDT by Jaxsun McCarthy Huggan
Modified:	2016-05-20 13:00 EDT (History)
CC List:	0 users

See Also:	Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit Git Commit Git Commit Git Commit Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jaxsun McCarthy Huggan

2016-05-04 19:53:30 EDT

Currently Mylyn reads the task list into a DOM then traverses the DOM to read the queries/tasks/categories in the task list. This uses a lot of memory and can cause out of memory errors when reading a large task list. Switching to a streaming approach would be much more efficient in this regard.

Comment 1 Jaxsun McCarthy Huggan

2016-05-04 19:55:22 EDT

I've written a POC of a SAX parser for reading the task list and it appears to work. I will push a review but would like to do some more testing before doing so.

Comment 2 Eclipse Genie

2016-05-04 20:03:15 EDT

New Gerrit change created: https://git.eclipse.org/r/72114

Comment 3 Eclipse Genie

2016-05-16 19:44:36 EDT

New Gerrit change created: https://git.eclipse.org/r/72860

Comment 4 Eclipse Genie

2016-05-16 19:52:38 EDT

New Gerrit change created: https://git.eclipse.org/r/72861

Comment 5 Eclipse Genie

2016-05-16 19:59:49 EDT

New Gerrit change created: https://git.eclipse.org/r/72862

Comment 6 Eclipse Genie

2016-05-18 00:02:14 EDT

New Gerrit change created: https://git.eclipse.org/r/72989

Comment 7 Eclipse Genie

2016-05-18 00:02:16 EDT

New Gerrit change created: https://git.eclipse.org/r/72988

Comment 8 Eclipse Genie

2016-05-18 18:16:57 EDT

Gerrit change https://git.eclipse.org/r/72114 was merged to [master].
Commit: http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.tasks.git/commit/?id=8d958cc06f60633412164e2d8fddc3ec907ae413

Comment 9 Eclipse Genie

2016-05-18 18:17:29 EDT

Gerrit change https://git.eclipse.org/r/72860 was merged to [master].
Commit: http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.tasks.git/commit/?id=7f3f9dc21e4b3ff6afd680c835277f08da7c124d

Comment 10 Eclipse Genie

2016-05-18 18:17:56 EDT

Gerrit change https://git.eclipse.org/r/72861 was merged to [master].
Commit: http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.tasks.git/commit/?id=8b94c80c870632a73daf1512a6f0ed20622e4683

Comment 11 Eclipse Genie

2016-05-18 18:18:58 EDT

Gerrit change https://git.eclipse.org/r/72862 was merged to [master].
Commit: http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.tasks.git/commit/?id=7b91dd13af3a2e8b6bdcfe05f701e58f57cbdc1c

Comment 12 Eclipse Genie

2016-05-18 18:19:19 EDT

Gerrit change https://git.eclipse.org/r/72988 was merged to [master].
Commit: http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.tasks.git/commit/?id=1cf9130cc747348693e2b3632f0a53ae3aaeeb53

Comment 13 Eclipse Genie

2016-05-18 18:55:19 EDT

Gerrit change https://git.eclipse.org/r/72989 was merged to [master].
Commit: http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.tasks.git/commit/?id=b9a7552f5892b88fb40727c55db62c63864fbd68

Comment 14 Jaxsun McCarthy Huggan

2016-05-18 20:15:32 EDT

In addition to moving to SAX this change introduced a significant performance improvement for large task list loading and deprecated the task list migration which was done for task lists from Mylyn 2.0.

Sam, can you please let me know what I need to update so that integrators know about he deprecation of the migration, and users know that Mylyn 2.0 task lists are no longer supported.

Comment 15 Sam Davis

2016-05-19 13:44:00 EDT

Can you add an entry to the porting guide (https://wiki.eclipse.org/Mylyn/Porting_Guide) for 3.20 saying that migrators will no longer be invoked? I will update https://projects.eclipse.org/projects/mylyn/releases/3.20/review now.

Comment 16 Sam Davis

2016-05-19 13:52:17 EDT

It would be a good idea to send a message to mylyn-integrators with a link to the porting guide (which should link to this bug).

Comment 17 Jaxsun McCarthy Huggan

2016-05-19 14:20:34 EDT

Thank you Sam, I will do that.

Comment 18 Jaxsun McCarthy Huggan

2016-05-19 18:54:38 EDT

I've updated that wiki, once the update is approved I'll send an email to integrators.

Comment 19 Jaxsun McCarthy Huggan

2016-05-20 13:00:36 EDT

The Wiki update is visible and I've emailed the integrators mailing list.