Bug 492454 - Add support for implicit auto-save in the UI
Summary: Add support for implicit auto-save in the UI
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: All All
: P3 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-26 10:02 EDT by Bruno Medeiros CLA
Modified: 2019-01-10 14:35 EST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bruno Medeiros CLA 2016-04-26 10:02:00 EDT
Add support for "implicit" editor saving if auto-save is on. Namely:

* Automatically save the editor if the user clicks on the close button or an action - without asking for confirmation.
* Don't show the dirty mark on an editor.
* Disable the revert action.
Comment 1 Dani Megert CLA 2016-04-26 10:36:16 EDT
(In reply to Bruno Medeiros from comment #0)
> Add support for "implicit" editor saving if auto-save is on. Namely:
> 
> * Automatically save the editor if the user clicks on the close button or an
> action - without asking for confirmation.

> * Don't show the dirty mark on an editor.
-1

> * Disable the revert action.
-1
Comment 2 Bruno Medeiros CLA 2016-04-28 08:48:03 EDT
Why a -1 to those changes? 
What's helpful about the dirty editor mark if auto-save is on? At this point it becomes just a indicator of internal state, not useful to a regular user. It's likely even more annoying if the user wants to have lower auto-save delay than the default.

As for the revert action, having that action enabled allows for a race condition to occur - the user invokes revert but the autosave save was triggered in the meanwhile, and the revert fails.
Comment 3 Bruno Medeiros CLA 2016-04-29 06:16:12 EDT
To follow up on this, I don't really care much about what is done to the Revert action: I don't expect users will be using it if auto-save is on, so in practice it doesn't matter much either way.

But the editor dirty mark is problematic. I think it's important to able to get rid of it, at least with an additional preference. Would that not be acceptable? BTW, I'm thinking of submitting a patch for this issue.
Comment 4 Dani Megert CLA 2016-05-02 03:37:23 EDT
(In reply to Bruno Medeiros from comment #2)
> Why a -1 to those changes? 
> What's helpful about the dirty editor mark if auto-save is on? At this point
> it becomes just a indicator of internal state, not useful to a regular user.
> It's likely even more annoying if the user wants to have lower auto-save
> delay than the default.

And it's even more useful if the user wants to have a higher auto-save delay.