Bug 491312 - [Quick Access] Add shortcut to tooltip of Quick Access
Summary: [Quick Access] Add shortcut to tooltip of Quick Access
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.6 M7   Edit
Assignee: Patrik Suzzi CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2016-04-08 05:42 EDT by Lars Vogel CLA
Modified: 2016-04-21 09:08 EDT (History)
4 users (show)

See Also:


Attachments
Example: OneNote (1.40 KB, image/png)
2016-04-08 05:45 EDT, Oliver Sievers CLA
no flags Details
Example: Outlook (2.26 KB, image/png)
2016-04-08 05:48 EDT, Oliver Sievers CLA
no flags Details
Screenshot of a prototype implementation for a smaller quickaccess (29.99 KB, image/png)
2016-04-08 06:11 EDT, Lars Vogel CLA
no flags Details
Windows 7, system font Tahoma 8 (24.85 KB, image/png)
2016-04-19 08:00 EDT, Markus Keller CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2016-04-08 05:42:39 EDT
We should promote the usage of Quick Access more in our user interface. I think for that we should add the shortcut to the message. To avoid that the box gets really huge, we should reduce the font size. 

I prototyped that and I think it looks really good. Attached a screenshot. 

The box is still to big, I plan to reduces its size even.
Comment 1 Oliver Sievers CLA 2016-04-08 05:45:00 EDT
Created attachment 260799 [details]
Example: OneNote
Comment 2 Lars Vogel CLA 2016-04-08 05:46:45 EDT
(In reply to Oliver Sievers from comment #1)
> Created attachment 260799 [details]
> Example: OneNote

Thanks for this example from one note, Oliver.
Comment 3 Oliver Sievers CLA 2016-04-08 05:48:36 EDT
Created attachment 260800 [details]
Example: Outlook

This is from outlook
Comment 4 Lars Vogel CLA 2016-04-08 06:11:50 EDT
Created attachment 260801 [details]
Screenshot of a prototype implementation for a smaller quickaccess
Comment 5 Lars Vogel CLA 2016-04-11 17:44:02 EDT
Test change https://git.eclipse.org/r/#/c/70278/
Comment 7 Lars Vogel CLA 2016-04-13 05:32:02 EDT
(In reply to Eclipse Genie from comment #6)
> Gerrit change https://git.eclipse.org/r/70278 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?id=92d960f677998ee9a551f0ecad093d8eda857696

This ones add the shortcut to the Quick Access box. Currently we are "always" user Ctrl+3, Patrik plans to provide a fix to dynamically look up the shortcut. We plan to use this bug report also for this polishment.
Comment 8 Eclipse Genie CLA 2016-04-13 06:00:50 EDT
New Gerrit change created: https://git.eclipse.org/r/70543
Comment 9 Patrik Suzzi CLA 2016-04-13 06:03:04 EDT
In windows, 
This is how it looks with Master: http://i.imgur.com/fZ33kYl.png
I added a workaround with change 70543 https://git.eclipse.org/r/#/c/70543/
and now it looks better: http://i.imgur.com/N9BcbPF.png
Comment 11 Lars Vogel CLA 2016-04-13 06:12:05 EDT
(In reply to Patrik Suzzi from comment #9)
> In windows, 
> This is how it looks with Master: http://i.imgur.com/fZ33kYl.png
> I added a workaround with change 70543 https://git.eclipse.org/r/#/c/70543/
> and now it looks better: http://i.imgur.com/N9BcbPF.png

Thanks, looks also good on GTK.
Comment 12 Eclipse Genie CLA 2016-04-13 12:38:33 EDT
New Gerrit change created: https://git.eclipse.org/r/70577
Comment 13 Patrik Suzzi CLA 2016-04-13 12:44:46 EDT
I'm displaying the real shourtcut with this change https://git.eclipse.org/r/#/c/70577/

Please, review this in MacOs, and Linux and share your thoughts.
Note: there is a workaround for which I'll report a new bug.
Comment 14 Eclipse Genie CLA 2016-04-14 16:20:58 EDT
New Gerrit change created: https://git.eclipse.org/r/70706
Comment 16 Lars Vogel CLA 2016-04-15 04:42:01 EDT
(In reply to Eclipse Genie from comment #15)
> Gerrit change https://git.eclipse.org/r/70577 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?id=e15a97e485cdcf4d72e31c407f252277fabcded6

Thanks Patrik and Brian.

The only "drawback" of this solution is that if the user has different shortcuts for different scopes that we will not update this shortcut. But I think that scenario is really esoteric and it is better that we do not trigger updates all the time in the Quick Access field if the binding context is changing. If there is a real need for that, please create a new bug report.

I merged the change so that we also see the correct keybinding on Mac (and not my hard-coded string). If Brian finds issues with this on Mac, we might have to revert the change but from his previous comments the old change seemed to have work for him and we have "only" changed the way we are listening to changes.
Comment 17 Markus Keller CLA 2016-04-19 07:59:38 EDT
The font is too small. You shouldn't use other fonts than the system font.
Comment 18 Markus Keller CLA 2016-04-19 08:00:32 EDT
Created attachment 261076 [details]
Windows 7, system font Tahoma 8
Comment 19 Lars Vogel CLA 2016-04-19 08:46:09 EDT
(In reply to Markus Keller from comment #17)
> The font is too small. You shouldn't use other fonts than the system font.

Do we have a smaller official font definition which we can use? Using the normal system font will make this quick access box very big.
Comment 20 Patrik Suzzi CLA 2016-04-20 11:56:13 EDT
(In reply to Markus Keller from comment #18)
> Created attachment 261076 [details]
> Windows 7, system font Tahoma 8

Markus, I would like to exclude we're in the same case as Bug 492102. 

Could you please press CTRL+3 multiple times and, alternating, change the focus between the Search Field and other active Views?

Does the font size decrease?

Thanks for your time.
Comment 21 Lars Vogel CLA 2016-04-20 12:08:02 EDT
Patrik and I discussed that offline, we agree that we move the shortcut to the tooltip to use system font for "Quick Access". Patrik plans to provide a Gerrit for that.
Comment 22 Eclipse Genie CLA 2016-04-20 13:13:10 EDT
New Gerrit change created: https://git.eclipse.org/r/71092
Comment 24 Lars Vogel CLA 2016-04-21 09:08:25 EDT
Looks good to me. Thanks Patrik