Bug 490713 - [GTK] Maximized shells and visibility changes
Summary: [GTK] Maximized shells and visibility changes
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2016-03-30 12:37 EDT by Alexandra Buzila CLA
Modified: 2020-08-16 08:18 EDT (History)
3 users (show)

See Also:


Attachments
tests (4.11 KB, application/x-zip-compressed)
2016-03-30 12:37 EDT, Alexandra Buzila CLA
no flags Details
PlainSWT_Example (2.99 KB, application/octet-stream)
2016-05-31 11:21 EDT, Eugen Neufeld CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandra Buzila CLA 2016-03-30 12:37:30 EDT
Created attachment 260629 [details]
tests

There are some issues with maximized shells when their visibility changes, on GTK:

   - the getMaximized() method will return false for a maximized shell that was hidden
   - if the visibility of a maximized shell is changed from true to false and then back to true again, the shell will no longer be maximized when made visible
   - when a maximized shell is unmaximized, the location of the shell is restored to it's previous values. However, if a maximized shell is hidden and while being hidden is unmaximized, it's position will be the default one (0,0 or similar)

I am attaching some unit tests that can be used to see the problems more exactly.

This behaviour was observed in e4, causing a maximized part to be unmaximized on a perspective back and forth switch. 

I have a fix for this, I will submit it shortly.
Comment 1 Eclipse Genie CLA 2016-03-30 13:05:27 EDT
New Gerrit change created: https://git.eclipse.org/r/69550
Comment 2 Eugen Neufeld CLA 2016-05-31 11:21:39 EDT
Created attachment 262132 [details]
PlainSWT_Example

This is a plain SWT example of the testcases provided by Alexandra.
Comment 3 Eric Williams CLA 2016-05-31 11:52:09 EDT
(In reply to Eugen Neufeld from comment #2)
> Created attachment 262132 [details]
> PlainSWT_Example
> 
> This is a plain SWT example of the testcases provided by Alexandra.

Alright, I'll take a look at the patch again sometime today or tomorrow.
Comment 4 Eric Williams CLA 2018-08-16 15:28:04 EDT
Ping, is this still relevant?
Comment 5 Eugen Neufeld CLA 2018-08-22 08:04:34 EDT
I retested this on GTK 2.24.32-1ubuntu1 and with Version: 3.22.30-1ubuntu1

Issue is still there, and is not fixed by the patch anymore.

We will try to provide a working patch for Gtk 3 (as 2 will be dropped), but I cannot guarantee when we will be able to find the time to do so.
Comment 6 Eclipse Genie CLA 2020-08-16 08:18:31 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.