Bug 490700 - Use varargs constructor from MessageDialog in Platform.ui
Summary: Use varargs constructor from MessageDialog in Platform.ui
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.6 M7   Edit
Assignee: Patrik Suzzi CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on: 472690 472784
Blocks:
  Show dependency tree
 
Reported: 2016-03-30 11:21 EDT by Lars Vogel CLA
Modified: 2016-04-11 18:47 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2016-03-30 11:21:39 EDT 
+++ This bug was initially created as a clone of Bug #472784 +++

For the continuation of the work in Bug 472690.
Comment 1 Eclipse Genie CLA 2016-04-06 05:50:47 EDT 
New Gerrit change created: https://git.eclipse.org/r/70001
Comment 2 Patrik Suzzi CLA 2016-04-06 05:52:05 EDT 
In the proposed change, I replaced constructors:
MessageDialog(Shell, String, Image, String, int, String[], int)
with new parametrized ones:
MessageDialog(Shell, String, Image, String, int, int, String...)

We can do the same for PDE, JDT, and org.eclips.ui.texteditor.
Comment 3 Lars Vogel CLA 2016-04-06 07:10:30 EDT 
(In reply to Patrik Suzzi from comment #2)
> We can do the same for PDE, JDT, and org.eclips.ui.texteditor.

If you plan to do that, please open new bug reports for that but if that is done as part of the FEEP is suggested to focus on more important bugs, instead of such cleanups. These things can also be easily done in one of our hackathons.
Comment 4 Patrik Suzzi CLA 2016-04-06 09:40:12 EDT 
Thanks. 
I will search for more important Platform UI bugs.
Comment 6 Lars Vogel CLA 2016-04-11 18:47:25 EDT 
Thanks Patrik