Community
Participate
Working Groups
4.6 M6, but even broken in 3.8. intro branding image does not appear under Windows. It works on Linux
It also works in the preview where one can choose the theme.
The preview is a generated PNG.
What format is the branding image in? I am asking because of finding related to our Splash screen (which is BMP). See https://wiki.eclipse.org/Platform-releng/Updating_Branding#Splash_screen But to quote here: = = = = Note: If your image program offers a choice, such as GIMP 2.8.10 does, it is important to save the bmp WITHOUT color space information saved or, else, the splash screen will not be displayed on Windows .... apparently a silent failure to read a "modern" BMP file (watch bug 439573). = = = = = Not sure if there is any similar bugs with PNG files. Just trying to be helpful.
(In reply to David Williams from comment #3) > What format is the branding image in? http://git.eclipse.org/c/platform/eclipse.platform.git/plain/platform/org.eclipse.sdk/intro-eclipse.png
David: that's not an issue here, the Intro/Welcome is an embedded SWT Browser instance. Dani: Did the other icons show? Can you attach a screenshot? I think this is bug 490116. Could you open the internal browser and visit https://www.whatismybrowser.com?
(In reply to Brian de Alwis from comment #5) > Dani: Did the other icons show? Yes. > Could you open the internal browser and visit > https://www.whatismybrowser.com? Internet Explorer 11 on Windows 7
Created attachment 260717 [details] Slate theme
Created attachment 260718 [details] Solstice theme
Very weird: I tried again using 3.8 and then the icon appear. Deleted the workspace and tried again: icon was missing!
This disappearing icon seems to be caused by the generation an MS/IE-specific filter in the Intro's IntroHTMLGenerator to work around bugs in IE5.5. Opening up the rendered HTML in IE8 [1] brings up a warning that scripts and ActiveX controls are disabled. But removing this code means that the icon appears super-sized for IE < 11, similar to what Noopur shows on https://bugs.eclipse.org/bugs/attachment.cgi?id=261240 [1] Launch with the `org.eclipse.ui.intro/debug/toolbar=true` in your debug/tracing options and you'll see a little notebook icon that will pop up the current page into your browser
New Gerrit change created: https://git.eclipse.org/r/72119
I've put up two variants of the patch. The first removes the filter-generation code entirely. The second makes the filter-generation conditional on IE<9 as background-size is reported to work on IE9+ [1]. I verified that the branding image is shown on IE 11 and Edge. The second is somewhat preferred IMHO as it effectively causes the images to disappear on IE8 which is preferrable to having oversized images. [1] http://caniuse.com/#search=background-size
+1 for RC1 with minor corrections (see Gerrit change).
Gerrit change https://git.eclipse.org/r/72119 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=2c355fd21d97d7d855816e81b27ebca21412fce7
Verified in eclipse-SDK-I20160509-2000-win32-x86_64.
