Bug 490474 - The SSH2 key management page should use 2048 bits minimum, 4096 preferred, for keys
Summary: The SSH2 key management page should use 2048 bits minimum, 4096 preferred, fo...
Status: CLOSED DUPLICATE of bug 404714
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 4.6   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform Team Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-25 22:10 EDT by Alex Blewitt CLA
Modified: 2019-07-12 11:42 EDT (History)
3 users (show)

See Also:

Attachments
patches RSA keys generation to 2048 bits (1.28 KB, patch)
2019-07-12 11:42 EDT, Alexander Levsha CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Blewitt CLA 2016-03-25 22:10:15 EDT 
Generating a key via the SSH2 preference pane allows RSA or DSA keys to be generated with 1024 bits. However, this is generally seen as not secure enough and is lower than the ssh-keygen default of 2048 bits.

We should ideally generate at least 2048 bits, preferably 4096 bits, or provide a way for the user to specify the lengths and details. Additionally since the use of DSA has been called into question perhaps we should just focus on RSA, or promote that over DSA by re-ordering the fields.
Comment 1 Brian de Alwis CLA 2016-03-28 22:02:50 EDT 
Moving to Platform/Team since the SSH2 preference page is org.eclipse.jsch.internal.ui.preference.PreferencePage.
Comment 2 Alexander Kurtakov CLA 2017-12-06 08:52:49 EST 

*** This bug has been marked as a duplicate of bug 404714 ***
Comment 3 Alexander Levsha CLA 2019-07-12 11:42:51 EDT 
Created attachment 279261 [details]
patches RSA keys generation to 2048 bits

Bitbucket has rejected the RSA-1024 key generated by Eclipse. DSA-1024 was accepted but is deprecated elsewhere (e.g. OpenSSH).
This really needs to be finally updated.

I made a small patch for org.eclipse.jsch.ui/src/org/eclipse/jsch/internal/ui/preference/PreferencePage.java
to generate RSA keys with length of 2048. I left DSA keys length at 1024 bits as it was since i'm not sure whether 2048 is supported.
I didn't test the patch but it's very simple: just pass another parameter to JSch and emit appropriate text comment.