Bug 490361 - Polish Smart Project Importer
Summary: Polish Smart Project Importer
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.6 M7   Edit
Assignee: Mickael Istria CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 472614
Blocks: 487298
  Show dependency tree
 
Reported: 2016-03-24 05:49 EDT by Lars Vogel CLA
Modified: 2016-04-28 01:57 EDT (History)
7 users (show)

See Also:
Lars.Vogel: pmc_approved+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2016-03-24 05:49:41 EDT 
The new project importer has several issues which should be fixed for M7:

The know issues are reported via https://bugs.eclipse.org/bugs/show_bug.cgi?id=472614#c44

--------

"This method MUST BE be stateless (ideally static)" is not an API. 

ProjectConfigurator#getConfigurationWizard() is a deprecated method with an outdated comment. How can you release something like this as an API? It's a shame that you even need to bother the PMC now to request removal of that method in M7.
------

Mickael, can you please work on this for M7?
Comment 1 Eclipse Genie CLA 2016-03-24 10:18:51 EDT 
New Gerrit change created: https://git.eclipse.org/r/69249
Comment 2 Eclipse Genie CLA 2016-04-01 06:43:03 EDT 
New Gerrit change created: https://git.eclipse.org/r/69698
Comment 5 Markus Keller CLA 2016-04-27 15:48:49 EDT 
Looks better now. Fixed a few minor Javadoc issues and pushed to master
Comment 6 Mickael Istria CLA 2016-04-28 01:57:46 EDT 
Thanks Markus.