Community
Participate
Working Groups
Perhaps there is a better title, but what I mean is related to the way the qualifier is updated. A recent example motivated me opening this bug. We have started to do Y-builds based on a few projects that have BETA_JAVA9 branches. And the first one, yesterday, had comparator errors due to SWT not having updated qualifier. http://download.eclipse.org/eclipse/downloads/drops4/Y20160303-0800/ Or more exactly, http://download.eclipse.org/eclipse/downloads/drops4/Y20160303-0800/buildlogs/comparatorlogs/buildtimeComparatorUnanticipated.log.txt = = = = = = = = What is unclear to me, is why you can't "update qualifier" every time there is any change? I understand then some of them may be "wasted", but ... as far as I know they are not in short supply. I am sure you may have a reason that I simply do not know about, but ... I do think it's important we should be able to do an I-build (or Y-build) at any time and get the correct version of SWT. = = = = = = = = If it is a matter that "you are not yet sure" if something should go into an I-build (or Y-build) perhaps we should reconsider the integration/master approach?
I've CC'd Markus as he might better understand your system and give advice (perhaps just to me! :)
(In reply to David Williams from comment #1) > I've CC'd Markus as he might better understand your system and give advice Not good enough, passing the ball to Lakshmi and Arun. Could be a result from bug 477711. However, I don't think a fully-automated build input is feasible at this time, since the qualifiers of all SWT bundles still need to be synchronized. This could only work for free if we accepted a "build input" commit after each and every real commit. I guess the best solution for now would be a way for David (or the SDK build) to force a build input. I know that the native build can't currently run on eclipse.org infrastructure, but maybe the simpler tagging job could be moved over? BTW: If you wondered about the unanticipated change in org.eclipse.ua.tests: It's OK. In http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=f562c7ab0b00eed80a4ece7b6cbfd7225bc263ee , the internal org.eclipse.help.internal.UAElement#getChildren(Class) got generified in an incompatible way that changed the return type from Object to Object[]. No problem, since it's not API and just referenced from a test, but we may have to touch org.eclipse.ua.tests to silence the problem.
(In reply to Markus Keller from comment #2) > (In reply to David Williams from comment #1) > > I've CC'd Markus as he might better understand your system and give advice > > Not good enough, passing the ball to Lakshmi and Arun. > > Could be a result from bug 477711. However, I don't think a fully-automated > build input is feasible at this time, since the qualifiers of all SWT > bundles still need to be synchronized. This could only work for free if we > accepted a "build input" commit after each and every real commit. Thanks for the comments, Markus. I definitely agree with bug 477711 so do not mean for that to be reverted. I also am not that concerned about things being "off" an hour or two but seems now things are off for "days" at a time. Plus, things often do not "go right" even before an I-build so things are not tagged correctly due to a failed build, or network issue (if I have heard correctly). Is there a reason the "master/integration" approach was abandoned? That is, I-builds could come from "integration branch" (for SWT) and your initial check-in of binaries would go into "master" for nightly builds. Then when you are ready at whatever point you want, not necessarily "right before an I-build", perhaps even multiple times a week, or at times skip weeks, you could update the 'tag' in question, and merge master into integration? (Or, rebase, or whatever best approach is). I suspect, then, your "tagging" and your "merge" could be automated in the same script? These are all just suggestions to improve our process. No criticism. Thanks,
Is this still relevant?
(In reply to Eric Williams from comment #4) > Is this still relevant? We have SWT tagging and qualifier update running 1 hour before every I build. Also I-build will fail if the qualifier update is not done. I would say this is not that relevant anymore. but we can still improve a bit on updating qualifier every time.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
We are running SWT build input as part of I-build now. So we will not see this problem anymore
