489035 – [Dark][GTK] Available software dialog drop-down has mixed colours for items

Bug 489035 - [Dark][GTK] Available software dialog drop-down has mixed colours for items

Summary: [Dark][GTK] Available software dialog drop-down has mixed colours for items

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	SWT (show other bugs)
Version:	4.6
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.17 M1
Assignee:	Soraphol (Paul) Damrongpiriyapong
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	563540 563541
	Show dependency tree

Reported:	2016-03-04 10:26 EST by Robert Munteanu
Modified:	2020-06-11 16:54 EDT (History)
CC List:	4 users (show)

See Also:	Gerrit Change Git Commit

Attachments
Available sites dropdown (74.56 KB, image/png) 2016-03-04 10:27 EST, Robert Munteanu	no flags	Details
Without background applied (33.52 KB, image/png) 2020-06-04 12:17 EDT, Soraphol (Paul) Damrongpiriyapong	no flags	Details
With background applied (38.04 KB, image/png) 2020-06-04 12:17 EDT, Soraphol (Paul) Damrongpiriyapong	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Robert Munteanu

2016-03-04 10:26:39 EST

Running a build of Eclipse Neon

Version: Neon Milestone 4 (4.6.0M5)
Build id: 20160203-2351

on an openSUSE Tumbleweed Linux machine ( KDE/Plasma Workspace 5.5.4, GTK 3.18.7 ). After switching to the dark theme and restarting Eclipse I opened the Install software dialog and noticed that the repositories drop-down list has mixed colours - list background is a darker grey while the item background is a lighter grey.

Comment 1 Robert Munteanu

2016-03-04 10:27:13 EST

Created attachment 260093 [details]
Available sites dropdown

Comment 2 Lars Vogel

2016-03-04 14:09:35 EST

Thanks Robert. Any chance that you can provide Gerrit reviews for the required changes?

Comment 3 Robert Munteanu

2016-04-01 11:23:47 EDT

Sorry, I doubt I will find the time to do that in the near future.

Comment 4 Lars Vogel

2020-05-19 06:05:24 EDT

Looks good on windows, must be a Linux issue

Comment 5 Eclipse Genie

2020-06-03 17:25:40 EDT

New Gerrit change created: https://git.eclipse.org/r/164099

Comment 6 Soraphol (Paul) Damrongpiriyapong

2020-06-04 12:17:16 EDT

Created attachment 283168 [details]
Without background applied

Wondering if I get feedback on what Windows has for their dropdown color? I have attached the two ways it can be done.

Comment 7 Soraphol (Paul) Damrongpiriyapong

2020-06-04 12:17:31 EDT

Created attachment 283169 [details]
With background applied

Comment 8 Alexander Kurtakov

2020-06-04 12:20:35 EDT

(In reply to Soraphol (Paul) Damrongpiriyapong from comment #7)
> Created attachment 283169 [details]
> With background applied

Definitely better and more consistent!

Comment 9 Lars Vogel

2020-06-08 09:37:36 EDT

(In reply to Alexander Kurtakov from comment #8)
> (In reply to Soraphol (Paul) Damrongpiriyapong from comment #7)
> > Created attachment 283169 [details]
> > With background applied
> 
> Definitely better and more consistent!

+1

Comment 10 Eclipse Genie

2020-06-10 05:44:37 EDT

Gerrit change https://git.eclipse.org/r/164099 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=f3c1d0f95c47c1ee66a642149112beae2241178e

Comment 11 Soraphol (Paul) Damrongpiriyapong

2020-06-11 16:54:56 EDT

Verified 

Eclipse Platform
Version: 2020-09 (4.17)
Build id: I20200610-1800
OS: Linux, v.5.6.14-300.fc32.x86_64, x86_64 / gtk 3.24.20
Java version: 1.8.0_252