Bug 48846 - [Workbench] Tab order in views is broken
Summary: [Workbench] Tab order in views is broken
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC All
: P1 major (vote)
Target Milestone: ---   Edit
Assignee: Michael Van Meekeren CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
: 48331 (view as bug list)
Depends on: 23566
Blocks: 10846 37276
  Show dependency tree
 
Reported: 2003-12-16 09:48 EST by Tod Creasey CLA
Modified: 2004-05-04 18:25 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2003-12-16 09:48:05 EST
20031216

You cannot tab around views or tool items on GTK. You can in Windows.

STEPS
1) Go to the a view
2)  Select Tab, Shift Tab or Control Tab. None of these allow navigation 
anywhere.

I suspect this is an SWT issue but I am logging tio UI in case it s a 
keybindigns problem
Comment 1 Douglas Pollock CLA 2003-12-16 10:22:04 EST
On Windows, I can tab between the active view and items on the toolbar (but not
between views)
On GTK, I can tab around the active view.

You seem to be indicating something more severe than this.  Could you be a bit
more precise?
Comment 2 Tod Creasey CLA 2003-12-16 11:03:56 EST
If you look the the CVS Repositories view I cannot tab anywhere using any 
combination. Gte there via Ctrl+F7 and then try from there.
Comment 3 Douglas Pollock CLA 2003-12-16 11:28:56 EST
SWT: Sounds like a problem with you guys.  We don't trap tab events.
Comment 4 Grant Gayed CLA 2003-12-16 12:30:58 EST
*** Bug 48331 has been marked as a duplicate of this bug. ***
Comment 5 Tod Creasey CLA 2004-03-05 10:46:13 EST
This is now a general problem. In Windows you cannot tab to give focus to the 
current tab from most views. When you can (Threads and Monitors can do this) 
when you can move to the next tab but the label of the tab is not passed on to 
MSAA.

Upping to major as this affects us everywhere. Also see Bug 10846
Comment 6 Nick Edgar CLA 2004-03-06 08:18:24 EST
I believe the problem with tabbing in views was introduced by us in the new 
look work.  The workbench used to set the tab order for a ViewPane explicitly 
to include the view, its toolbars, the main toolbar, the shortcut bar, in 
roughly top-down, left-to-right order.  Should be easy to tell if this is an 
SWT problem with a standalone example.
Comment 7 Carolyn MacLeod CLA 2004-03-12 13:37:38 EST
If I simply run the ControlExample (uses platform TabFolder) or the 
CustomControlExample (uses CTabFolder) I can tab through all controls on all 
platforms *except* ToolBar on GTK. In other words, the tabs that you see in 
eclipse views and editors should all be keyboard accessible using TAB or 
CTRL+TAB in the forward direction, or SHIFT+TAB to go in the reverse order.

Nick is correct that something has changed with the new look. In fact in build 
20040310, the eclipse tab order is fairly badly broken on Windows also. Each 
view may need to have its tab order explicitly set, or you need to carefully 
go and redo whatever it is that you did before the new look was introduced.
I don't really know why this is necessary - perhaps because of the 

Tod, can you make sure the correct UI person is assigned to this bug? Thanks.
We will keep bug 23566, which specifically covers the problem with toolbar on 
GTK.
Comment 8 Carolyn MacLeod CLA 2004-04-06 11:18:31 EDT
Changing summary to indicate that tab order is broken, and moving back to UI.
Note that SWT is working on the "toolbar buttons don't take focus" problem 
(bug 23566).
Comment 9 Tod Creasey CLA 2004-05-04 18:25:37 EDT
Confirmed that this is fixed due to the tab folder work done by SWT in build 
20040504