Bug 48832 - [CommandMgmt] Some key bindings don't work
Summary: [CommandMgmt] Some key bindings don't work
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P1 major (vote)
Target Milestone: 3.0 M6   Edit
Assignee: Chris McLaren CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-12-16 06:44 EST by Philipe Mulet CLA
Modified: 2003-12-17 06:15 EST (History)
5 users (show)

See Also:


Attachments
Philippe's Configuration Details (61.56 KB, text/plain)
2003-12-16 09:56 EST, Douglas Pollock CLA
no flags Details
Entry from the .log (3.56 KB, text/plain)
2003-12-16 11:41 EST, Philipe Mulet CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philipe Mulet CLA 2003-12-16 06:44:11 EST
Build 20031216

The key binding for triggering incremental builds is no longer operational in 
this build. This makes it pretty unusable.

Do you have regression tests for key bindings ?
Comment 1 Philipe Mulet CLA 2003-12-16 06:50:18 EST
Trying to restore default in key binding preferences did not help either.
ctrl-S doesn't work either in Java editor.
Comment 2 Philipe Mulet CLA 2003-12-16 07:13:38 EST
Problem occurs in any subsequent sessions.
I can provide my workspace if you need it.
Comment 3 Nick Edgar CLA 2003-12-16 09:26:26 EST
See also bug 48486.

Philippe has posted his workspace to ott4f under: /teams/Eclipse-
Platform/anon/in/48486.

Veronika also asks: are you using a French keyboard?
Comment 4 Philipe Mulet CLA 2003-12-16 09:30:38 EST
I am using a plain US Keyboard with US win2000 install.
Comment 5 Philipe Mulet CLA 2003-12-16 09:31:37 EST
I am seeing this behavior on both my machine (laptop + workstation).
Jerome got the same behavior after upgrading to this built.

Folks in ZRH saw some of it as well.
Comment 6 Douglas Pollock CLA 2003-12-16 09:35:17 EST
From the sounds of things, this is a duplicate of 48486.  Please re-open if 
you feel differently.

*** This bug has been marked as a duplicate of 48486 ***
Comment 7 Douglas Pollock CLA 2003-12-16 09:46:52 EST
Sorry, I think this is a separate bug.  Nick believes that Ctrl+B is not in an 
action set.  Let's make this a separate bug, rather than making Bug 48486 even 
longer than it already is.
Comment 8 Douglas Pollock CLA 2003-12-16 09:54:35 EST
------- From Philippe Mulet 2003-12-16 07:12 ------- 
I am still using an old workspace which was previously running on 20031211, 
where I had some key binding issues (different sessions had different 
problems). But this time around it feels like all key bindings are gone, and I 
do not get any different behavior from a session to the other.

------- From Nick Edgar 2003-12-16 09:34 ------- 
What Philippe is seeing sounds more like the original problem reported here, 
not the problem with action set handlers.  It's not working when first started 
up.  He did not say he was switching perspectives.

Philippe has posted his workspace to ott4f under /teams/Eclipse-
Platform/anon/in/48486.
Comment 9 Douglas Pollock CLA 2003-12-16 09:56:17 EST
Created attachment 7185 [details]
Philippe's Configuration Details

Help > About > Configuration Details
Comment 10 Philipe Mulet CLA 2003-12-16 10:10:37 EST
More info:
- problem doesn't occur with freshly created workspace
- problem doesn't occur when reopening 6 months old workspace
Comment 11 Douglas Pollock CLA 2003-12-16 10:16:26 EST
I cannot reproduce using my workspace on Windows XP or Linux-GTK.  Currently 
stalled with infra problems getting Philippe's workspace.
Comment 12 Philipe Mulet CLA 2003-12-16 11:41:36 EST
Created attachment 7190 [details]
Entry from the .log
Comment 13 Douglas Pollock CLA 2003-12-16 12:05:42 EST
I've managed to reproduce the problem using a self-hosted Eclipse inside an 
I20031211 build with PlatformUI from the head -- using Philippe's workspace.  
I'll attach listeners and see try to see what's going on.
Comment 14 Steve Northover CLA 2003-12-16 12:11:07 EST
Do you want some help?
Comment 15 Douglas Pollock CLA 2003-12-16 12:16:41 EST
I've managed to track down the problem in gross terms.  It is not a problem 
with SWT nor the key bindings.  It is a problem "above" key bindings -- 
somewhere in the command manager or higher.

Listener.handleEvent(type=1,stateMask=0x0,keyCode=0x40000,character=0x0)
Listener.handleEvent(type=1,stateMask=0x40000,keyCode=0x20000,character=0x0)
Listener.handleEvent(type=1,stateMask=0x60000,keyCode=0x74,character=0x14)
WorkbenchKeyboard.press(potentialKeyStrokes=[CTRL+SHIFT+T],dialogOnly=false)
WorkbenchKeyboard.executeCommand
(commandId=org.eclipse.jdt.ui.navigate.open.type)
	action=null
Comment 16 Philipe Mulet CLA 2003-12-16 12:26:49 EST
Log entry in comment #12 seems unrelated. When emptying log and restarting, no 
such entry is added again either on startup or when pressing any offending key 
sequence.
Comment 17 Jerome Lanneluc CLA 2003-12-16 12:30:10 EST
FYI, I managed to finally workaround the problem by following these steps:
1. Close all windows except one that contains the Java perspectives
2. Window->Preferences->Export...
3. Window->Preferences->Restore Defaults
4. Exit/restart workbench
5. Notice that key bindings were working (notably Ctrl+S and Ctrl+B)
6. Window->Preferences->Import... (my saved preferences)
7. Exit/Restart workbench
8. Notice that key bindings were still working
Comment 18 Douglas Pollock CLA 2003-12-16 12:41:45 EST
Test case is again "Ctrl+Shift+R" (Open Resource).  (Note that the broken key 
bindings are not restricted to action sets.)  A handler is never defined for 
this command.  Compare with a fresh workspace, and a handler is defined.
Comment 19 Philipe Mulet CLA 2003-12-16 12:48:54 EST
Even simpler steps to solve the problem:
- Close all windows but one
- Exit and restart.
Comment 20 Philipe Mulet CLA 2003-12-16 12:50:44 EST
However, once you reopen another window, then problem reappears again. Seems 
like the wrong window is getting the event ? 
Comment 21 Douglas Pollock CLA 2003-12-16 13:30:59 EST
The key is in the number of windows opened.  Any workbench opened with two or 
more windows can have the effect of "clobbering" handlers.  Philippe's 
workbench was a particularly apparent example because both of his workbench 
windows opened to the same perspective.

This is command management stuff.  Chris is aware of the problem, and working 
on it.
Comment 22 Douglas Pollock CLA 2003-12-16 14:09:12 EST
Chris has submitted a fix, and I've verified the fix to work (as near as I can 
see) on Philippe's workspace.  This fix will appear in I200312161600.  Could 
those people seeing the problem please double-check the fix as well?  Thank 
you.
Comment 23 Philipe Mulet CLA 2003-12-16 19:18:43 EST
I confirm that this problem is addressed when running my workspace on 
20031216:1717.

Thanks!
Comment 24 Jerome Lanneluc CLA 2003-12-17 06:15:22 EST
Confirmed as well with I200312162000.